Close and delete pnacl temp files when compile or link fails.

ppapi/native_client/src/trusted/plugin/json_manifest.cc

 /*
  * Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <algorithm>
 
 #include "native_client/src/trusted/plugin/json_manifest.h"
 
@@ skipping 101 matching lines @@
     return false;
   }
   // Check for unknown dictionary members.
   Json::Value::Members members = dictionary.getMemberNames();
   for (size_t i = 0; i < members.size(); ++i) {
     nacl::string property_name = members[i];
     if (!FindMatchingProperty(property_name,
                               valid_keys,
                               valid_key_count)) {
       // TODO(jvoung): Should this set error_string and return false?
-      PLUGIN_PRINTF(("WARNING: '%s' property '%s' has unknown key '%s'.",
+      PLUGIN_PRINTF(("WARNING: '%s' property '%s' has unknown key '%s'.\n",
                      parent_key.c_str(),
                      container_key.c_str(), property_name.c_str()));
     }
   }
   // Check for required members.
   for (size_t i = 0; i < required_key_count; ++i) {
     if (!dictionary.isMember(required_keys[i])) {
       nacl::stringstream error_stream;
       error_stream << parent_key << " property '" << container_key
                    << "' does not have required key: '"
@@ skipping 96 matching lines @@
     if (!FindMatchingProperty(property_name,
                               kManifestISAProperties,
                               NACL_ARRAY_SIZE(kManifestISAProperties))) {
       PLUGIN_PRINTF(("IsValidISADictionary: unrecognized ISA '%s'.\n",
                      property_name.c_str()));
     }
     // Could be "arch/portable" : URLSpec, or
     // it could be "arch/portable" : { "pnacl-translate": URLSpec }
     // for executables that need to be translated.
     Json::Value property_value = dictionary[property_name];
-    if (!IsValidPnaclTranslateSpec(property_value, property_name,
-                                   parent_key, error_string) &&
-        !IsValidUrlSpec(property_value, property_name, parent_key,
-                        error_string)) {
+    if (!IsValidUrlSpec(property_value, property_name, parent_key,
+                        error_string) &&
+        !IsValidPnaclTranslateSpec(property_value, property_name,
+                                   parent_key, error_string)) {
       return false;
     }
   }
 
   // TODO(elijahtaylor) add ISA resolver here if we expand ISAs to include
   // micro-architectures that can resolve to multiple valid sandboxes.
   bool has_isa = dictionary.isMember(sandbox_isa);
   bool has_portable = dictionary.isMember(kPortableKey);
 
   if (!has_isa && !has_portable) {
@@ skipping 301 matching lines @@
     error_info->SetReport(
         ERROR_MANIFEST_RESOLVE_URL,
         nacl::string("ResolveKey: no such \"files\" entry: ") + key);
     return false;
   }
   return GetKeyUrl(files, rest, sandbox_isa_, this, prefer_portable_,
                    full_url, cache_identity, error_info, pnacl_translate);
 }
 
 }  // namespace plugin