Remove --simple-data-source and convert WebMediaPlayerImpl::Initialize() to a void function.

Remove --simple-data-source and convert WebMediaPlayerImpl::Initialize() to a void function.

This is a step in removing WebMediaPlayerImpl::Initialize() entirely.

BUG=109958
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117447

[scherkus (not reviewing), 2012-01-12 01:52:30]

first to reply -> first to review

[Ami GONE FROM CHROMIUM, 2012-01-12 03:10:35]

LGTM % comment q

http://codereview.chromium.org/9195001/diff/1/webkit/media/webmediaplayer_impl.h
File webkit/media/webmediaplayer_impl.h (left):

http://codereview.chromium.org/9195001/diff/1/webkit/media/webmediaplayer_imp...
webkit/media/webmediaplayer_impl.h:89: // rendering. |collection| should contain
filter factories for:
Why remove this chunk of comment?  At least parts of it seem worth keeping.

[scherkus (not reviewing), 2012-01-12 03:32:20]

http://codereview.chromium.org/9195001/diff/1/webkit/media/webmediaplayer_impl.h
File webkit/media/webmediaplayer_impl.h (left):

http://codereview.chromium.org/9195001/diff/1/webkit/media/webmediaplayer_imp...
webkit/media/webmediaplayer_impl.h:89: // rendering. |collection| should contain
filter factories for:
On 2012/01/12 03:10:35, Ami Fischman wrote:
> Why remove this chunk of comment?  At least parts of it seem worth keeping.

Most of it is inaccurate -- I'll selectively add back a few parts.

[scherkus (not reviewing), 2012-01-12 03:45:27]

darin: webkit/ OWNERS
jam: content/ OWNERS

[jam, 2012-01-12 05:18:58]

content lgtm

http://codereview.chromium.org/9195001/diff/2002/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/9195001/diff/2002/content/renderer/render_view...
content/renderer/render_view_impl.cc:1981: DCHECK(media_player);
nit: DCHECK(ptr) isn't that useful, in release mode it does nothing. in debug
build the crash in the next line is just as good of a signal

[darin (slow to review), 2012-01-12 06:15:57]

LGTM

[scherkus (not reviewing), 2012-01-12 17:15:31]

thanks for the review!

http://codereview.chromium.org/9195001/diff/2002/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/9195001/diff/2002/content/renderer/render_view...
content/renderer/render_view_impl.cc:1981: DCHECK(media_player);
On 2012/01/12 05:18:59, John Abd-El-Malek wrote:
> nit: DCHECK(ptr) isn't that useful, in release mode it does nothing. in debug
> build the crash in the next line is just as good of a signal

Done.