| Index: webkit/media/webmediaplayer_impl.h
|
| diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h
|
| index b9600eca4de4a8b52d5c80a8a2900b02a31271be..a28a187fc8b1e85c0690949e376adc22e48efd39 100644
|
| --- a/webkit/media/webmediaplayer_impl.h
|
| +++ b/webkit/media/webmediaplayer_impl.h
|
| @@ -86,23 +86,18 @@ class WebMediaPlayerImpl
|
| // Construct a WebMediaPlayerImpl with reference to the client, and media
|
| // filter collection. By providing the filter collection the implementor can
|
| // provide more specific media filters that does resource loading and
|
| - // rendering. |collection| should contain filter factories for:
|
| - // 1. Data source
|
| - // 2. Audio renderer
|
| - // 3. Video renderer (optional)
|
| + // rendering.
|
| + //
|
| + // WebMediaPlayerImpl comes packaged with the following media filters:
|
| + // - URL fetching
|
| + // - Demuxing
|
| + // - Software audio/video decoding
|
| + // - Video rendering
|
| + //
|
| + // Clients are expected to add their platform-specific audio rendering media
|
| + // filter if they wish to hear any sound coming out the speakers, otherwise
|
| + // audio data is discarded and media plays back based on wall clock time.
|
| //
|
| - // There are some default filters provided by this method:
|
| - // 1. FFmpeg demuxer
|
| - // 2. FFmpeg audio decoder
|
| - // 3. FFmpeg video decoder
|
| - // 4. Video renderer
|
| - // 5. Null audio renderer
|
| - // The video renderer provided by this class is using the graphics context
|
| - // provided by WebKit to perform renderering. The simple data source does
|
| - // resource loading by loading the whole resource object into memory. Null
|
| - // audio renderer is a fake audio device that plays silence. Provider of the
|
| - // |collection| can override the default filters by adding extra filters to
|
| - // |collection| before calling this method.
|
| // This object takes ownership of the |audio_source_provider|.
|
| //
|
| // Callers must call |Initialize()| before they can use the object.
|
| @@ -115,8 +110,10 @@ class WebMediaPlayerImpl
|
| media::MediaLog* media_log);
|
| virtual ~WebMediaPlayerImpl();
|
|
|
| - // Finalizes initialization of the object.
|
| - bool Initialize(WebKit::WebFrame* frame, bool use_simple_data_source);
|
| + // Finalizes initialization of the object using the given WebFrame.
|
| + //
|
| + // TODO(scherkus): fold this into the constructor http://crbug.com/109958
|
| + void Initialize(WebKit::WebFrame* frame);
|
|
|
| virtual void load(const WebKit::WebURL& url);
|
| virtual void cancelLoad();
|
|
|