Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: content/renderer/render_view_impl.cc

Issue 9195001: Remove --simple-data-source and convert WebMediaPlayerImpl::Initialize() to a void function. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: no dcheck Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/content_switches.cc ('k') | webkit/media/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index cffbbbab0d89449a088db9e5b98b2602a973acee..f002c82bccba6003dd87130d3e921098e5621868 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1968,25 +1968,18 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
}
#endif
- webkit_media::WebMediaPlayerImpl* result_ptr;
+ webkit_media::WebMediaPlayerImpl* media_player = NULL;
if (!content::GetContentClient()->renderer()->OverrideCreateWebMediaPlayer(
this, client, AsWeakPtr(), collection, audio_source_provider,
message_loop_factory, media_stream_impl_.get(), render_media_log,
- &result_ptr)) {
- result_ptr = new webkit_media::WebMediaPlayerImpl(
+ &media_player)) {
+ media_player = new webkit_media::WebMediaPlayerImpl(
client, AsWeakPtr(), collection, audio_source_provider,
message_loop_factory, media_stream_impl_.get(), render_media_log);
}
- DCHECK(result_ptr);
- scoped_ptr<webkit_media::WebMediaPlayerImpl> result;
- result.reset(result_ptr);
-
- if (!result->Initialize(frame,
- cmd_line->HasSwitch(switches::kSimpleDataSource))) {
- return NULL;
- }
- return result.release();
+ media_player->Initialize(frame);
+ return media_player;
}
WebApplicationCacheHost* RenderViewImpl::createApplicationCacheHost(
« no previous file with comments | « content/public/common/content_switches.cc ('k') | webkit/media/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698