Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 9187015: Remove usage of using namespace, and cleanup trace_analyzer namespace (Closed)

Created:
8 years, 11 months ago by jbates
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove usage of using namespace, and cleanup trace_analyzer namespace Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117517

Patch Set 1 #

Patch Set 2 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -193 lines) Patch
M base/test/trace_event_analyzer.h View 5 chunks +108 lines, -58 lines 0 comments Download
M base/test/trace_event_analyzer.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 22 chunks +78 lines, -96 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/perf/rendering/latency_tests.cc View 4 chunks +21 lines, -14 lines 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbates
ptal nduca: chrome/test/rendering zmo: chrome/test/gpu phajdan: base/test
8 years, 11 months ago (2012-01-11 20:13:18 UTC) #1
Zhenyao Mo
On 2012/01/11 20:13:18, jbates wrote: > ptal > nduca: chrome/test/rendering > zmo: chrome/test/gpu > phajdan: ...
8 years, 11 months ago (2012-01-11 20:14:28 UTC) #2
Paweł Hajdan Jr.
LGTM
8 years, 11 months ago (2012-01-12 07:31:01 UTC) #3
nduca
lgtm
8 years, 11 months ago (2012-01-12 19:49:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9187015/7001
8 years, 11 months ago (2012-01-12 20:09:56 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-12 21:41:55 UTC) #6
Change committed as 117517

Powered by Google App Engine
This is Rietveld 408576698