Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: chrome/test/perf/frame_rate/frame_rate_tests.cc

Issue 9187015: Remove usage of using namespace, and cleanup trace_analyzer namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/gpu/gpu_feature_browsertest.cc ('k') | chrome/test/perf/rendering/latency_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/frame_rate/frame_rate_tests.cc
diff --git a/chrome/test/perf/frame_rate/frame_rate_tests.cc b/chrome/test/perf/frame_rate/frame_rate_tests.cc
index d43efcfa6b33be777943b9937603cb74a1c303e2..d207f43ec42a2c773e731669fcfb78c17335cb5b 100644
--- a/chrome/test/perf/frame_rate/frame_rate_tests.cc
+++ b/chrome/test/perf/frame_rate/frame_rate_tests.cc
@@ -121,15 +121,16 @@ class FrameRateTest
}
bool DidRunOnGpu(const std::string& json_events) {
- using namespace trace_analyzer;
+ using trace_analyzer::Query;
+ using trace_analyzer::TraceAnalyzer;
// Check trace for GPU accleration.
scoped_ptr<TraceAnalyzer> analyzer(TraceAnalyzer::Create(json_events));
gfx::GLImplementation gl_impl = gfx::kGLImplementationNone;
- const TraceEvent* gpu_event = analyzer->FindOneEvent(
- Query(EVENT_NAME) == Query::String("SwapBuffers") &&
- Query(EVENT_HAS_NUMBER_ARG, "GLImpl"));
+ const trace_analyzer::TraceEvent* gpu_event = analyzer->FindOneEvent(
+ Query::EventName() == Query::String("SwapBuffers") &&
+ Query::EventHasNumberArg("glimpl"));
if (gpu_event)
gl_impl = static_cast<gfx::GLImplementation>(
gpu_event->GetKnownArgAsInt("GLImpl"));
« no previous file with comments | « chrome/test/gpu/gpu_feature_browsertest.cc ('k') | chrome/test/perf/rendering/latency_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698