Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: base/test/trace_event_analyzer.cc

Issue 9187015: Remove usage of using namespace, and cleanup trace_analyzer namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/trace_event_analyzer.h ('k') | base/test/trace_event_analyzer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_event_analyzer.cc
diff --git a/base/test/trace_event_analyzer.cc b/base/test/trace_event_analyzer.cc
index a60250ab6fc2a3a84f6d1e24150deb39d6cae2d3..9813f14785ccbedc93d75e3c2ad2f446ab5b0a77 100644
--- a/base/test/trace_event_analyzer.cc
+++ b/base/test/trace_event_analyzer.cc
@@ -674,26 +674,26 @@ bool TraceAnalyzer::SetEvents(const std::string& json_events) {
}
void TraceAnalyzer::AssociateBeginEndEvents() {
- using namespace trace_analyzer;
+ using trace_analyzer::Query;
- Query begin(Query(EVENT_PHASE) == Query::Phase(TRACE_EVENT_PHASE_BEGIN));
- Query end(Query(EVENT_PHASE) == Query::Phase(TRACE_EVENT_PHASE_END));
- Query match(Query(EVENT_NAME) == Query(OTHER_NAME) &&
- Query(EVENT_CATEGORY) == Query(OTHER_CATEGORY) &&
- Query(EVENT_TID) == Query(OTHER_TID) &&
- Query(EVENT_PID) == Query(OTHER_PID));
+ Query begin(Query::EventPhase() == Query::Phase(TRACE_EVENT_PHASE_BEGIN));
+ Query end(Query::EventPhase() == Query::Phase(TRACE_EVENT_PHASE_END));
+ Query match(Query::EventName() == Query::OtherName() &&
+ Query::EventCategory() == Query::OtherCategory() &&
+ Query::EventTid() == Query::OtherTid() &&
+ Query::EventPid() == Query::OtherPid());
AssociateEvents(begin, end, match);
}
void TraceAnalyzer::AssociateStartFinishEvents() {
- using namespace trace_analyzer;
+ using trace_analyzer::Query;
- Query begin(Query(EVENT_PHASE) == Query::Phase(TRACE_EVENT_PHASE_START));
- Query end(Query(EVENT_PHASE) == Query::Phase(TRACE_EVENT_PHASE_FINISH));
- Query match(Query(EVENT_NAME) == Query(OTHER_NAME) &&
- Query(EVENT_CATEGORY) == Query(OTHER_CATEGORY) &&
- Query(EVENT_ID) == Query(OTHER_ID));
+ Query begin(Query::EventPhase() == Query::Phase(TRACE_EVENT_PHASE_START));
+ Query end(Query::EventPhase() == Query::Phase(TRACE_EVENT_PHASE_FINISH));
+ Query match(Query::EventName() == Query::OtherName() &&
+ Query::EventCategory() == Query::OtherCategory() &&
+ Query::EventId() == Query::OtherId());
AssociateEvents(begin, end, match);
}
« no previous file with comments | « base/test/trace_event_analyzer.h ('k') | base/test/trace_event_analyzer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698