Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: chrome/test/gpu/gpu_feature_browsertest.cc

Issue 9187015: Remove usage of using namespace, and cleanup trace_analyzer namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/trace_event_analyzer_unittest.cc ('k') | chrome/test/perf/frame_rate/frame_rate_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/gpu/gpu_feature_browsertest.cc
diff --git a/chrome/test/gpu/gpu_feature_browsertest.cc b/chrome/test/gpu/gpu_feature_browsertest.cc
index 37758cb29718efa3f86fbeb8d1aef5baf99b4cdb..4c9a6fa5b49454ea5da6d8470cd92b610e78be52 100644
--- a/chrome/test/gpu/gpu_feature_browsertest.cc
+++ b/chrome/test/gpu/gpu_feature_browsertest.cc
@@ -90,7 +90,8 @@ class GpuFeatureTest : public InProcessBrowserTest {
}
void RunTest(const FilePath& url, GpuResultFlags expectations) {
- using namespace trace_analyzer;
+ using trace_analyzer::Query;
+ using trace_analyzer::TraceAnalyzer;
ASSERT_TRUE(tracing::BeginTracing("test_gpu"));
@@ -102,7 +103,7 @@ class GpuFeatureTest : public InProcessBrowserTest {
scoped_ptr<TraceAnalyzer> analyzer(TraceAnalyzer::Create(json_events));
analyzer->AssociateBeginEndEvents();
- TraceEventVector events;
+ trace_analyzer::TraceEventVector events;
// This measurement is flaky, because the GPU process is sometimes
// started before the test (always with force-compositing-mode on CrOS).
@@ -113,7 +114,7 @@ class GpuFeatureTest : public InProcessBrowserTest {
// Check for swap buffers if expected:
if (expectations & EXPECT_GPU_SWAP_BUFFERS) {
- EXPECT_GT(analyzer->FindEvents(Query(EVENT_NAME) ==
+ EXPECT_GT(analyzer->FindEvents(Query::EventName() ==
Query::String("SwapBuffers"), &events),
size_t(0));
}
« no previous file with comments | « base/test/trace_event_analyzer_unittest.cc ('k') | chrome/test/perf/frame_rate/frame_rate_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698