Detect sync server communication errors

chrome/browser/sync/sessions/status_controller.cc

Index: chrome/browser/sync/sessions/status_controller.cc
diff --git a/chrome/browser/sync/sessions/status_controller.cc b/chrome/browser/sync/sessions/status_controller.cc
index bf9416d51d52d2601e5e3cd0985a7795ee662f4a..64dd4295a7dab50cc3a05db8adc547a27d747073 100644
--- a/chrome/browser/sync/sessions/status_controller.cc
+++ b/chrome/browser/sync/sessions/status_controller.cc
@@ -211,6 +211,19 @@ void StatusController::set_sync_protocol_error(
   shared_.error.mutate()->sync_protocol_error = error;
 }
 
+void StatusController::set_download_updates_result(const SyncerError result) {
+  shared_.error.mutate()->download_updates_result = result;

[tim (not reviewing), 2012/01/10 17:17:34]

If you add stuff to this class, it's a good idea to add to
StatusControllerUnittest (to avoid refactorings or code moves causing bugs like
the one you just fixed with conflict_sets_built).

[rlarocque, 2012/01/10 20:40:56]

Done.

I usually wouldn't bother to test getter and setter methods, but that seems to
be the convention for this class.

[tim (not reviewing), 2012/01/11 01:09:00]

Right... I made it that way because this file is particularly susceptible to
copy/paste errors.

+}
+
+void StatusController::set_post_commit_result(const SyncerError result) {
+  shared_.error.mutate()->post_commit_result = result;
+}
+
+void StatusController::set_process_commit_response_result(
+    const SyncerError result) {
+  shared_.error.mutate()->process_commit_response_result = result;
+}
+
 void StatusController::set_commit_set(const OrderedCommitSet& commit_set) {
   DCHECK(!group_restriction_in_effect_);
   shared_.commit_set = commit_set;