Detect sync server communication errors

chrome/browser/sync/sessions/session_state.h

Index: chrome/browser/sync/sessions/session_state.h
diff --git a/chrome/browser/sync/sessions/session_state.h b/chrome/browser/sync/sessions/session_state.h
index 448ecc1cd28cee74ac3fbad82786868ba9d1324b..a51c0e95ab3501a86c21b714d23904caaf0ed6b1 100644
--- a/chrome/browser/sync/sessions/session_state.h
+++ b/chrome/browser/sync/sessions/session_state.h
@@ -105,6 +105,11 @@ struct ErrorCounters {
 
   // Any protocol errors that we received during this sync session.
   SyncProtocolError sync_protocol_error;
+
+  // Records the most recent results of PostCommit and GetUpdates commands.
+  SyncerError download_updates_result;

[tim (not reviewing), 2012/01/10 17:17:34]

If we only care about the last result, perhaps we should name this
last_download_updates_result to be accurate.

[rlarocque, 2012/01/10 20:40:56]

Done.

It's not that we only care about the most recent result, it's that it would be
difficult to respond to anything but the last error.  We currently don't have
the ability to handle errors during the sync cycle, so we'd have to save all of
them.  What would we do with a list of errors?  I think the only sensible thing
to do would be to ignore all but the most recent error, since we can't do
anything about the older errors.

The best solution would be to handle errors closer to where they occur, but that
won't be happening for a while.  This is a temporary compromise.

+  SyncerError post_commit_result;
+  SyncerError process_commit_response_result;
 };
 
 // Caller takes ownership of the returned dictionary.