Detect sync server communication errors

chrome/browser/sync/sessions/status_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sessions/status_controller.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "chrome/browser/sync/protocol/sync_protocol_error.h"
@@ skipping 193 matching lines @@
 
 void StatusController::increment_num_server_overwrites() {
   shared_.syncer_status.mutate()->num_server_overwrites++;
 }
 
 void StatusController::set_sync_protocol_error(
     const SyncProtocolError& error) {
   shared_.error.mutate()->sync_protocol_error = error;
 }
 
+void StatusController::set_download_updates_result(const SyncerError result) {
+  shared_.error.mutate()->download_updates_result = result;

[tim (not reviewing), 2012/01/10 17:17:34]

If you add stuff to this class, it's a good idea to add to
StatusControllerUnittest (to avoid refactorings or code moves causing bugs like
the one you just fixed with conflict_sets_built).

[rlarocque, 2012/01/10 20:40:56]

Done.

I usually wouldn't bother to test getter and setter methods, but that seems to
be the convention for this class.

[tim (not reviewing), 2012/01/11 01:09:00]

Right... I made it that way because this file is particularly susceptible to
copy/paste errors.

+}
+
+void StatusController::set_post_commit_result(const SyncerError result) {
+  shared_.error.mutate()->post_commit_result = result;
+}
+
+void StatusController::set_process_commit_response_result(
+    const SyncerError result) {
+  shared_.error.mutate()->process_commit_response_result = result;
+}
+
 void StatusController::set_commit_set(const OrderedCommitSet& commit_set) {
   DCHECK(!group_restriction_in_effect_);
   shared_.commit_set = commit_set;
 }
 
 void StatusController::update_conflict_sets_built(bool built) {
   shared_.control_params.conflict_sets_built |= built;
 }
 void StatusController::update_conflicts_resolved(bool resolved) {
   shared_.control_params.conflict_sets_built |= resolved;
@@ skipping 74 matching lines @@
 void StatusController::set_debug_info_sent() {
   shared_.control_params.debug_info_sent = true;
 }
 
 bool StatusController::debug_info_sent() const {
   return shared_.control_params.debug_info_sent;
 }
 
 }  // namespace sessions
 }  // namespace browser_sync