Detect sync server communication errors

chrome/browser/sync/sessions/sync_session.h

Index: chrome/browser/sync/sessions/sync_session.h
diff --git a/chrome/browser/sync/sessions/sync_session.h b/chrome/browser/sync/sessions/sync_session.h
index abed10eac7fee2729f73822592e96fcf2acd02f9..2da276a43100759150a8faf72bbb52f382f80e1b 100644
--- a/chrome/browser/sync/sessions/sync_session.h
+++ b/chrome/browser/sync/sessions/sync_session.h
@@ -112,6 +112,14 @@ class SyncSession {
   // engine again.
   bool HasMoreToSync() const;
 
+  // Returns true if this session completed without experiencing any sort of
+  // errors.

[tim (not reviewing), 2012/01/10 17:17:34]

"any sort of errors" is pretty vague.  I know we can't make it too specific
since it will rot, but a high level summary would be nice (network errors, proto
errors, ...)

[rlarocque, 2012/01/10 20:40:56]

All successes look alike, but there are many kinds of failures.  What I'm trying
to say here is that this returns false if the cycle was not a success, and true
otherwise.

I'll try to reword the comment.

+  //
+  // Returns false if SyncShare has not been called on this session yet, or
+  // if ResetTransientState() has been called on this session since the last
+  // call to SyncShare.
+  bool Succeeded() const;
+
   // Collects all state pertaining to how and why |s| originated and unions it
   // with corresponding state in |this|, leaving |s| unchanged.  Allows |this|
   // to take on the responsibilities |s| had (e.g. certain data types) in the