Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 915002: Create a toplevel gfx/ dir and seed it with icon_util.... (Closed)

Created:
10 years, 9 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Create a toplevel gfx/ dir and seed it with icon_util. TBR=darin BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41528

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -972 lines) Patch
M app/app.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M app/app_base.gypi View 2 chunks +1 line, -2 lines 0 comments Download
D app/gfx/icon_util.h View 1 chunk +0 lines, -196 lines 0 comments Download
D app/gfx/icon_util.cc View 1 chunk +0 lines, -489 lines 0 comments Download
D app/gfx/icon_util_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M build/all.gyp View 1 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A gfx/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A gfx/empty.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A gfx/gfx.gyp View 1 1 chunk +72 lines, -0 lines 0 comments Download
A + gfx/icon_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + gfx/icon_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + gfx/icon_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A gfx/run_all_unittests.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M views/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/table/native_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/tree/tree_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M views/window/window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/pepper_test_plugin/test_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
10 years, 9 months ago (2010-03-13 08:26:12 UTC) #1
darin (slow to review)
10 years, 9 months ago (2010-03-15 19:58:38 UTC) #2
LGTM

On Sat, Mar 13, 2010 at 12:26 AM, <ben@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Create a toplevel gfx/ dir and seed it with icon_util.
>
> TBR=darin
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/915002
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     app/app.gyp
>  M     app/app_base.gypi
>  D     app/gfx/icon_util.h
>  D     app/gfx/icon_util.cc
>  D     app/gfx/icon_util_unittest.cc
>  M     build/all.gyp
>  M     chrome/DEPS
>  M     chrome/browser/aeropeek_manager.cc
>  M     chrome/browser/icon_loader_win.cc
>  M     chrome/browser/jumplist.cc
>  M     chrome/browser/task_manager_resource_providers.cc
>  M     chrome/browser/views/frame/glass_browser_frame_view.cc
>  M     chrome/browser/views/tab_icon_view.cc
>  M     chrome/browser/web_applications/web_app.cc
>  M     chrome/chrome.gyp
>  A     gfx/DEPS
>  A     gfx/empty.cc
>  A     gfx/gfx.gyp
>  A  +  gfx/icon_util.h
>  A  +  gfx/icon_util.cc
>  A  +  gfx/icon_util_unittest.cc
>  A     gfx/run_all_unittests.cc
>  M     views/DEPS
>  M     views/controls/table/native_table_win.cc
>  M     views/controls/table/table_view.cc
>  M     views/controls/tree/tree_view.cc
>  M     views/window/window_win.cc
>  M     webkit/tools/pepper_test_plugin/test_page.html
>
>
>

Powered by Google App Engine
This is Rietveld 408576698