Change code in base (primarily unit tests) to use Sleep(TimeDelta).

Change code in base (primarily unit tests) to use Sleep(TimeDelta).

BUG=108171
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116065

[Ted Vessenes, 2011-12-30 22:09:56]

This is a conversion of the Sleep() interface for most code under base.  Changes
were straight forward for the most part, but there were a few judgment calls in
there.

[brettw, 2011-12-31 17:52:05]

http://codereview.chromium.org/9055001/diff/1/base/process_util_unittest.cc
File base/process_util_unittest.cc (right):

http://codereview.chromium.org/9055001/diff/1/base/process_util_unittest.cc#n...
base/process_util_unittest.cc:99: base::TimeDelta waited =
base::TimeDelta::FromMilliseconds(0);
You can omit the "= ...", TimeDeltas are initialized to 0 by default.

http://codereview.chromium.org/9055001/diff/1/base/time.h
File base/time.h (right):

http://codereview.chromium.org/9055001/diff/1/base/time.h#newcode104
base/time.h:104: TimeDelta operator+(const TimeDelta other) const {
Why did you change these lines? It seems like it doesn't matter since these are
copies, and we normally don't pass "const int" as parameters.

[Ted Vessenes, 2011-12-31 18:45:39]

I had some compilation errors that seemed I thought were caused by the lack of a
const interface, but I just tried removing the const qualifiers and it seems to
compile fine.  I'll remove them.

On 2011/12/31 17:52:05, brettw wrote:
> http://codereview.chromium.org/9055001/diff/1/base/process_util_unittest.cc
> File base/process_util_unittest.cc (right):
> 
>
http://codereview.chromium.org/9055001/diff/1/base/process_util_unittest.cc#n...
> base/process_util_unittest.cc:99: base::TimeDelta waited =
> base::TimeDelta::FromMilliseconds(0);
> You can omit the "= ...", TimeDeltas are initialized to 0 by default.
> 
> http://codereview.chromium.org/9055001/diff/1/base/time.h
> File base/time.h (right):
> 
> http://codereview.chromium.org/9055001/diff/1/base/time.h#newcode104
> base/time.h:104: TimeDelta operator+(const TimeDelta other) const {
> Why did you change these lines? It seems like it doesn't matter since these
are
> copies, and we normally don't pass "const int" as parameters.

[brettw, 2011-12-31 18:52:59]

okay, LGTM with that

[commit-bot: I haz the power, 2011-12-31 19:17:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9055001/3002

[commit-bot: I haz the power, 2011-12-31 19:35:40]

Try job failure for 9055001-3002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Ted Vessenes, 2011-12-31 20:09:43]

Compilation error was caused by windows specific code that directly called
Sleep() rather than PlatformThread::Sleep().  I changed all the windows code to
use PlatformThread, even though it's just a wrapper around ::Sleep().

If for some reason the Windows code is supposed to call Sleep directly, please
let me know.  Otherwise I'll submit this back to the bots.

[commit-bot: I haz the power, 2011-12-31 21:11:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9055001/8001

[commit-bot: I haz the power, 2011-12-31 22:53:54]

Change committed as 116065