base/time_unittest.cc - Issue 9055001: Change code in base (primarily unit tests) to use Sleep(TimeDelta).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/time_unittest.cc

Issue 9055001: Change code in base (primarily unit tests) to use Sleep(TimeDelta). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Qualify windows Sleep calls to go through PlatformThread. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/time_unittest.cc

diff --git a/base/time_unittest.cc b/base/time_unittest.cc

index 6ba03b8c114133336bf9a504860afb597315b973..261b831fe85cd20f10c6e23bc8c5cb70da6d81df 100644

--- a/base/time_unittest.cc

+++ b/base/time_unittest.cc

@@ -311,7 +311,7 @@ TEST_F(TimeTest, ParseTimeTestInvalidString) {

TEST(TimeTicks, Deltas) {

for (int index = 0; index < 50; index++) {

TimeTicks ticks_start = TimeTicks::Now();

- base::PlatformThread::Sleep(10);

+ base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(10));

TimeTicks ticks_stop = TimeTicks::Now();

TimeDelta delta = ticks_stop - ticks_start;

// Note: Although we asked for a 10ms sleep, if the

« no previous file with comments | « base/threading/watchdog_unittest.cc ('k') | base/time_win_unittest.cc » ('j') | no next file with comments »