Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: base/timer_unittest.cc

Issue 9055001: Change code in base (primarily unit tests) to use Sleep(TimeDelta). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Qualify windows Sleep calls to go through PlatformThread. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/time_win_unittest.cc ('k') | base/tools_sanity_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "base/message_loop.h" 6 #include "base/message_loop.h"
7 #include "base/task.h" 7 #include "base/task.h"
8 #include "base/timer.h" 8 #include "base/timer.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 260
261 { 261 {
262 base::DelayTimer<DelayTimerFatalTarget> timer( 262 base::DelayTimer<DelayTimerFatalTarget> timer(
263 FROM_HERE, TimeDelta::FromMilliseconds(50), &target, 263 FROM_HERE, TimeDelta::FromMilliseconds(50), &target,
264 &DelayTimerFatalTarget::Signal); 264 &DelayTimerFatalTarget::Signal);
265 timer.Reset(); 265 timer.Reset();
266 } 266 }
267 267
268 // When the timer is deleted, the DelayTimerFatalTarget should never be 268 // When the timer is deleted, the DelayTimerFatalTarget should never be
269 // called. 269 // called.
270 base::PlatformThread::Sleep(100); 270 base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
271 } 271 }
272 272
273 } // namespace 273 } // namespace
274 274
275 //----------------------------------------------------------------------------- 275 //-----------------------------------------------------------------------------
276 // Each test is run against each type of MessageLoop. That way we are sure 276 // Each test is run against each type of MessageLoop. That way we are sure
277 // that timers work properly in all configurations. 277 // that timers work properly in all configurations.
278 278
279 TEST(TimerTest, OneShotTimer) { 279 TEST(TimerTest, OneShotTimer) {
280 RunTest_OneShotTimer(MessageLoop::TYPE_DEFAULT); 280 RunTest_OneShotTimer(MessageLoop::TYPE_DEFAULT);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 OneShotTimerTester d(&did_run); 346 OneShotTimerTester d(&did_run);
347 { 347 {
348 MessageLoop loop(MessageLoop::TYPE_DEFAULT); 348 MessageLoop loop(MessageLoop::TYPE_DEFAULT);
349 a.Start(); 349 a.Start();
350 b.Start(); 350 b.Start();
351 } // MessageLoop destructs by falling out of scope. 351 } // MessageLoop destructs by falling out of scope.
352 } // OneShotTimers destruct. SHOULD NOT CRASH, of course. 352 } // OneShotTimers destruct. SHOULD NOT CRASH, of course.
353 353
354 EXPECT_FALSE(did_run); 354 EXPECT_FALSE(did_run);
355 } 355 }
OLDNEW
« no previous file with comments | « base/time_win_unittest.cc ('k') | base/tools_sanity_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698