base/threading/thread_collision_warner_unittest.cc - Issue 9055001: Change code in base (primarily unit tests) to use Sleep(TimeDelta).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_collision_warner_unittest.cc

Issue 9055001: Change code in base (primarily unit tests) to use Sleep(TimeDelta). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Qualify windows Sleep calls to go through PlatformThread. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/thread_collision_warner_unittest.cc

diff --git a/base/threading/thread_collision_warner_unittest.cc b/base/threading/thread_collision_warner_unittest.cc

index 4613955bfac958412691ed98b461cb76391f0eeb..d9e535b800874e8006f69f3f1695b080ed73e617 100644

--- a/base/threading/thread_collision_warner_unittest.cc

+++ b/base/threading/thread_collision_warner_unittest.cc

@@ -190,7 +190,7 @@ TEST(ThreadCollisionTest, MTScopedBookCriticalSectionTest) {

void push(int value) {

DFAKE_SCOPED_LOCK(push_pop_);

- base::PlatformThread::Sleep(5000);

+ base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(5));

}

int pop() {

@@ -248,7 +248,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedBookCriticalSectionTest) {

void push(int value) {

DFAKE_SCOPED_LOCK(push_pop_);

- base::PlatformThread::Sleep(2000);

+ base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(2));

}

int pop() {

@@ -318,7 +318,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedRecursiveBookCriticalSectionTest) {

void push(int) {

DFAKE_SCOPED_RECURSIVE_LOCK(push_pop_);

bar();

- base::PlatformThread::Sleep(2000);

+ base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(2));

}

int pop() {

« no previous file with comments | « base/threading/platform_thread_unittest.cc ('k') | base/threading/thread_unittest.cc » ('j') | no next file with comments »