Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed)

Created:
9 years ago by fschneider
Modified:
9 years ago
CC:
v8-dev, danno
Visibility:
Public.

Description

Remove unnecessary environment from LStoreKeyedFastElements. This was a left-over from a time when bounds-check was performed as part of this instruction. I also refactored and improved the code for smi-only arrays. R=vegorov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=10300

Patch Set 1 #

Patch Set 2 : Simplified and improved smi-only-array stores #

Patch Set 3 : removed one redundant smi-check #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -49 lines) Patch
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 chunks +17 lines, -9 lines 1 comment Download
M src/hydrogen-instructions.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years ago (2011-12-22 15:14:23 UTC) #1
fschneider
Ready for review. cc'ed danno for the smi-only-arrays part. http://codereview.chromium.org/9023006/diff/1007/src/hydrogen.cc File src/hydrogen.cc (left): http://codereview.chromium.org/9023006/diff/1007/src/hydrogen.cc#oldcode4403 src/hydrogen.cc:4403: ...
9 years ago (2011-12-22 16:00:03 UTC) #2
Vyacheslav Egorov (Chromium)
9 years ago (2011-12-22 16:22:09 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698