src/arm/lithium-codegen-arm.cc - Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: removed one redundant smi-check Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

===================================================================

--- src/arm/lithium-codegen-arm.cc (revision 10299)

+++ src/arm/lithium-codegen-arm.cc (working copy)

@@ -3404,13 +3404,6 @@

- // This instruction cannot handle the FAST_SMI_ONLY_ELEMENTS -> FAST_ELEMENTS

- // conversion, so it deopts in that case.

- if (instr->hydrogen()->ValueNeedsSmiCheck()) {

- __ tst(value, Operand(kSmiTagMask));

- DeoptimizeIf(ne, instr->environment());

- }

// Do the store.

if (instr->key()->IsConstantOperand()) {

ASSERT(!instr->hydrogen()->NeedsWriteBarrier());

« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')