Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: removed one redundant smi-check Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2005 matching lines...) Expand 10 before | Expand all | Expand 10 after
2016 ASSERT(instr->object()->representation().IsTagged()); 2016 ASSERT(instr->object()->representation().IsTagged());
2017 ASSERT(instr->key()->representation().IsInteger32()); 2017 ASSERT(instr->key()->representation().IsInteger32());
2018 2018
2019 LOperand* obj = UseRegister(instr->object()); 2019 LOperand* obj = UseRegister(instr->object());
2020 LOperand* val = needs_write_barrier 2020 LOperand* val = needs_write_barrier
2021 ? UseTempRegister(instr->value()) 2021 ? UseTempRegister(instr->value())
2022 : UseRegisterAtStart(instr->value()); 2022 : UseRegisterAtStart(instr->value());
2023 LOperand* key = needs_write_barrier 2023 LOperand* key = needs_write_barrier
2024 ? UseTempRegister(instr->key()) 2024 ? UseTempRegister(instr->key())
2025 : UseRegisterOrConstantAtStart(instr->key()); 2025 : UseRegisterOrConstantAtStart(instr->key());
2026 2026 return new(zone()) LStoreKeyedFastElement(obj, key, val);
2027 return AssignEnvironment(new(zone()) LStoreKeyedFastElement(obj, key, val));
2028 } 2027 }
2029 2028
2030 2029
2031 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement( 2030 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement(
2032 HStoreKeyedFastDoubleElement* instr) { 2031 HStoreKeyedFastDoubleElement* instr) {
2033 ASSERT(instr->value()->representation().IsDouble()); 2032 ASSERT(instr->value()->representation().IsDouble());
2034 ASSERT(instr->elements()->representation().IsTagged()); 2033 ASSERT(instr->elements()->representation().IsTagged());
2035 ASSERT(instr->key()->representation().IsInteger32()); 2034 ASSERT(instr->key()->representation().IsInteger32());
2036 2035
2037 LOperand* elements = UseRegisterAtStart(instr->elements()); 2036 LOperand* elements = UseRegisterAtStart(instr->elements());
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
2375 LOperand* key = UseOrConstantAtStart(instr->key()); 2374 LOperand* key = UseOrConstantAtStart(instr->key());
2376 LOperand* object = UseOrConstantAtStart(instr->object()); 2375 LOperand* object = UseOrConstantAtStart(instr->object());
2377 LIn* result = new(zone()) LIn(context, key, object); 2376 LIn* result = new(zone()) LIn(context, key, object);
2378 return MarkAsCall(DefineFixed(result, eax), instr); 2377 return MarkAsCall(DefineFixed(result, eax), instr);
2379 } 2378 }
2380 2379
2381 2380
2382 } } // namespace v8::internal 2381 } } // namespace v8::internal
2383 2382
2384 #endif // V8_TARGET_ARCH_IA32 2383 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698