Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/hydrogen-instructions.h

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: removed one redundant smi-check Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3915 matching lines...) Expand 10 before | Expand all | Expand 10 after
3926 } 3926 }
3927 3927
3928 bool NeedsWriteBarrier() { 3928 bool NeedsWriteBarrier() {
3929 if (value_is_smi()) { 3929 if (value_is_smi()) {
3930 return false; 3930 return false;
3931 } else { 3931 } else {
3932 return StoringValueNeedsWriteBarrier(value()); 3932 return StoringValueNeedsWriteBarrier(value());
3933 } 3933 }
3934 } 3934 }
3935 3935
3936 bool ValueNeedsSmiCheck() {
3937 return value_is_smi();
3938 }
3939
3940 virtual void PrintDataTo(StringStream* stream); 3936 virtual void PrintDataTo(StringStream* stream);
3941 3937
3942 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedFastElement) 3938 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedFastElement)
3943 3939
3944 private: 3940 private:
3945 ElementsKind elements_kind_; 3941 ElementsKind elements_kind_;
3946 }; 3942 };
3947 3943
3948 3944
3949 class HStoreKeyedFastDoubleElement: public HTemplateInstruction<3> { 3945 class HStoreKeyedFastDoubleElement: public HTemplateInstruction<3> {
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
4490 4486
4491 DECLARE_CONCRETE_INSTRUCTION(In) 4487 DECLARE_CONCRETE_INSTRUCTION(In)
4492 }; 4488 };
4493 4489
4494 #undef DECLARE_INSTRUCTION 4490 #undef DECLARE_INSTRUCTION
4495 #undef DECLARE_CONCRETE_INSTRUCTION 4491 #undef DECLARE_CONCRETE_INSTRUCTION
4496 4492
4497 } } // namespace v8::internal 4493 } } // namespace v8::internal
4498 4494
4499 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 4495 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« src/hydrogen.cc ('K') | « src/hydrogen.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698