Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 8949015: Allow the AudioLowLatencyInputOutput tests to run on bots where audio hardware is available. (Closed)

Created:
9 years ago by tommi (sloooow) - chröme
Modified:
9 years ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Allow the AudioLowLatencyInputOutput, WinAudioOutputTest and WinAudioInputTest tests to run on bots where audio hardware is available. The tests will succeed (to avoid breaking the tree) with a warning printed out on bots that don't have the necessary hardware. TEST=Run media_unittests on the build bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114638

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Add the win input/output tests as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M media/audio/audio_low_latency_input_output_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 2 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
9 years ago (2011-12-15 13:43:35 UTC) #1
henrika (OOO until Aug 14)
9 years ago (2011-12-15 15:34:28 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698