Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: media/audio/audio_low_latency_input_output_unittest.cc

Issue 8949015: Allow the AudioLowLatencyInputOutput tests to run on bots where audio hardware is available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add the win input/output tests as well Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/win/audio_low_latency_input_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_low_latency_input_output_unittest.cc
===================================================================
--- media/audio/audio_low_latency_input_output_unittest.cc (revision 114624)
+++ media/audio/audio_low_latency_input_output_unittest.cc (working copy)
@@ -110,11 +110,11 @@
// Convenience method which ensures that we are not running on the build
// bots and that at least one valid input and output device can be found.
bool CanRunAudioTests() {
- scoped_ptr<base::Environment> env(base::Environment::Create());
- if (env->HasVar("CHROME_HEADLESS"))
- return false;
- return (audio_manager()->HasAudioInputDevices() &&
- audio_manager()->HasAudioOutputDevices());
+ bool input = audio_manager()->HasAudioInputDevices();
+ bool output = audio_manager()->HasAudioOutputDevices();
+ LOG_IF(WARNING, !input) << "No input device detected.";
+ LOG_IF(WARNING, !output) << "No output device detected.";
+ return input && output;
}
private:
« no previous file with comments | « no previous file | media/audio/win/audio_low_latency_input_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698