Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8898036: base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
csilv
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114562

Patch Set 1 #

Total comments: 16

Patch Set 2 : Call SetResult() in custom CompletionCallbacks. #

Patch Set 3 : Review fixes. #

Patch Set 4 : Possible test fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -651 lines) Patch
M jingle/notifier/base/proxy_resolving_client_socket.h View 1 chunk +2 lines, -3 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.cc View 1 2 5 chunks +11 lines, -14 lines 0 comments Download
M net/base/test_completion_callback.h View 1 chunk +24 lines, -18 lines 0 comments Download
M net/base/test_completion_callback.cc View 1 2 1 chunk +20 lines, -17 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M net/http/http_pipelined_connection_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 11 chunks +20 lines, -20 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 6 chunks +12 lines, -19 lines 0 comments Download
M net/proxy/proxy_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 2 8 chunks +10 lines, -7 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 15 chunks +43 lines, -42 lines 0 comments Download
M net/socket/client_socket_handle.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_handle.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 3 83 chunks +231 lines, -225 lines 0 comments Download
M net/socket/client_socket_pool_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool_manager.cc View 1 5 chunks +17 lines, -48 lines 0 comments Download
M net/socket/deterministic_socket_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +10 lines, -8 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M net/socket/socks_client_socket_pool_unittest.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 2 5 chunks +11 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 22 chunks +42 lines, -42 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 1 2 17 chunks +80 lines, -57 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 7 chunks +28 lines, -39 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M net/spdy/spdy_websocket_stream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_job_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
9 years ago (2011-12-14 02:22:08 UTC) #1
csilv
lgtm http://codereview.chromium.org/8898036/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/8898036/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode8 jingle/notifier/base/proxy_resolving_client_socket.cc:8: #include "base/bind.h" #include base/bind_helpers.h http://codereview.chromium.org/8898036/diff/1/net/base/test_completion_callback.cc File net/base/test_completion_callback.cc (right): ...
9 years ago (2011-12-14 20:10:19 UTC) #2
James Hawkins
9 years ago (2011-12-14 20:59:05 UTC) #3 
http://codereview.chromium.org/8898036/diff/1/jingle/notifier/base/proxy_reso...
File jingle/notifier/base/proxy_resolving_client_socket.cc (right):

http://codereview.chromium.org/8898036/diff/1/jingle/notifier/base/proxy_reso...
jingle/notifier/base/proxy_resolving_client_socket.cc:8: #include "base/bind.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include base/bind_helpers.h

Done.

http://codereview.chromium.org/8898036/diff/1/net/base/test_completion_callba...
File net/base/test_completion_callback.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/base/test_completion_callba...
net/base/test_completion_callback.cc:7: #include "base/bind.h"
On 2011/12/14 20:10:19, csilv wrote:
> add #include base/bind_helpers.h

Done.

http://codereview.chromium.org/8898036/diff/1/net/http/http_stream_factory_im...
File net/http/http_stream_factory_impl_job.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/http/http_stream_factory_im...
net/http/http_stream_factory_impl_job.cc:7: #include "base/bind.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include base/bind_helpers.h

Done.

http://codereview.chromium.org/8898036/diff/1/net/proxy/proxy_service.cc
File net/proxy/proxy_service.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/proxy/proxy_service.cc#newc...
net/proxy/proxy_service.cc:9: #include "base/compiler_specific.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include "base/bind.h" & "base/bind_helpers.h"

Done.

http://codereview.chromium.org/8898036/diff/1/net/socket/client_socket_pool_b...
File net/socket/client_socket_pool_base_unittest.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/socket/client_socket_pool_b...
net/socket/client_socket_pool_base_unittest.cc:7: #include "base/callback.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include base/bind.h ,base/bind_helpers.h

Done.

http://codereview.chromium.org/8898036/diff/1/net/socket/socks_client_socket_...
File net/socket/socks_client_socket_pool.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/socket/socks_client_socket_...
net/socket/socks_client_socket_pool.cc:7: #include "base/time.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include base/bind.h, base/bind_helpers.h

Done.

http://codereview.chromium.org/8898036/diff/1/net/socket/ssl_client_socket_po...
File net/socket/ssl_client_socket_pool.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/socket/ssl_client_socket_po...
net/socket/ssl_client_socket_pool.cc:7: #include "base/metrics/field_trial.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include base/bind.h, base/bind_helpers.h

Done.

http://codereview.chromium.org/8898036/diff/1/net/socket/transport_client_soc...
File net/socket/transport_client_socket_pool_unittest.cc (right):

http://codereview.chromium.org/8898036/diff/1/net/socket/transport_client_soc...
net/socket/transport_client_socket_pool_unittest.cc:7: #include
"base/callback.h"
On 2011/12/14 20:10:19, csilv wrote:
> #include base/bind.h, base/bind_helpers.h

Done.

Powered by Google App Engine
This is Rietveld 408576698