Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: net/socket/socks_client_socket_pool_unittest.cc

Issue 8898036: base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Possible test fix. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/socks_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_pool.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/socks_client_socket_pool.h" 5 #include "net/socket/socks_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "net/base/mock_host_resolver.h" 10 #include "net/base/mock_host_resolver.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 SOCKSClientSocketPool pool_; 94 SOCKSClientSocketPool pool_;
95 ClientSocketPoolTest test_base_; 95 ClientSocketPoolTest test_base_;
96 }; 96 };
97 97
98 TEST_F(SOCKSClientSocketPoolTest, Simple) { 98 TEST_F(SOCKSClientSocketPoolTest, Simple) {
99 SOCKS5MockData data(false); 99 SOCKS5MockData data(false);
100 data.data_provider()->set_connect_data(MockConnect(false, 0)); 100 data.data_provider()->set_connect_data(MockConnect(false, 0));
101 transport_client_socket_factory_.AddSocketDataProvider(data.data_provider()); 101 transport_client_socket_factory_.AddSocketDataProvider(data.data_provider());
102 102
103 ClientSocketHandle handle; 103 ClientSocketHandle handle;
104 int rv = handle.Init("a", ignored_socket_params_, LOW, NULL, &pool_, 104 int rv = handle.Init("a", ignored_socket_params_, LOW, CompletionCallback(),
105 BoundNetLog()); 105 &pool_, BoundNetLog());
106 EXPECT_EQ(OK, rv); 106 EXPECT_EQ(OK, rv);
107 EXPECT_TRUE(handle.is_initialized()); 107 EXPECT_TRUE(handle.is_initialized());
108 EXPECT_TRUE(handle.socket()); 108 EXPECT_TRUE(handle.socket());
109 } 109 }
110 110
111 TEST_F(SOCKSClientSocketPoolTest, Async) { 111 TEST_F(SOCKSClientSocketPoolTest, Async) {
112 SOCKS5MockData data(true); 112 SOCKS5MockData data(true);
113 transport_client_socket_factory_.AddSocketDataProvider(data.data_provider()); 113 transport_client_socket_factory_.AddSocketDataProvider(data.data_provider());
114 114
115 TestOldCompletionCallback callback; 115 TestCompletionCallback callback;
116 ClientSocketHandle handle; 116 ClientSocketHandle handle;
117 int rv = handle.Init("a", ignored_socket_params_, LOW, &callback, &pool_, 117 int rv = handle.Init("a", ignored_socket_params_, LOW, callback.callback(),
118 BoundNetLog()); 118 &pool_, BoundNetLog());
119 EXPECT_EQ(ERR_IO_PENDING, rv); 119 EXPECT_EQ(ERR_IO_PENDING, rv);
120 EXPECT_FALSE(handle.is_initialized()); 120 EXPECT_FALSE(handle.is_initialized());
121 EXPECT_FALSE(handle.socket()); 121 EXPECT_FALSE(handle.socket());
122 122
123 EXPECT_EQ(OK, callback.WaitForResult()); 123 EXPECT_EQ(OK, callback.WaitForResult());
124 EXPECT_TRUE(handle.is_initialized()); 124 EXPECT_TRUE(handle.is_initialized());
125 EXPECT_TRUE(handle.socket()); 125 EXPECT_TRUE(handle.socket());
126 } 126 }
127 127
128 TEST_F(SOCKSClientSocketPoolTest, TransportConnectError) { 128 TEST_F(SOCKSClientSocketPoolTest, TransportConnectError) {
129 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider()); 129 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider());
130 socket_data->set_connect_data(MockConnect(false, ERR_CONNECTION_REFUSED)); 130 socket_data->set_connect_data(MockConnect(false, ERR_CONNECTION_REFUSED));
131 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get()); 131 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
132 132
133 ClientSocketHandle handle; 133 ClientSocketHandle handle;
134 int rv = handle.Init("a", ignored_socket_params_, LOW, NULL, &pool_, 134 int rv = handle.Init("a", ignored_socket_params_, LOW, CompletionCallback(),
135 BoundNetLog()); 135 &pool_, BoundNetLog());
136 EXPECT_EQ(ERR_PROXY_CONNECTION_FAILED, rv); 136 EXPECT_EQ(ERR_PROXY_CONNECTION_FAILED, rv);
137 EXPECT_FALSE(handle.is_initialized()); 137 EXPECT_FALSE(handle.is_initialized());
138 EXPECT_FALSE(handle.socket()); 138 EXPECT_FALSE(handle.socket());
139 } 139 }
140 140
141 TEST_F(SOCKSClientSocketPoolTest, AsyncTransportConnectError) { 141 TEST_F(SOCKSClientSocketPoolTest, AsyncTransportConnectError) {
142 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider()); 142 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider());
143 socket_data->set_connect_data(MockConnect(true, ERR_CONNECTION_REFUSED)); 143 socket_data->set_connect_data(MockConnect(true, ERR_CONNECTION_REFUSED));
144 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get()); 144 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
145 145
146 TestOldCompletionCallback callback; 146 TestCompletionCallback callback;
147 ClientSocketHandle handle; 147 ClientSocketHandle handle;
148 int rv = handle.Init("a", ignored_socket_params_, LOW, &callback, &pool_, 148 int rv = handle.Init("a", ignored_socket_params_, LOW, callback.callback(),
149 BoundNetLog()); 149 &pool_, BoundNetLog());
150 EXPECT_EQ(ERR_IO_PENDING, rv); 150 EXPECT_EQ(ERR_IO_PENDING, rv);
151 EXPECT_FALSE(handle.is_initialized()); 151 EXPECT_FALSE(handle.is_initialized());
152 EXPECT_FALSE(handle.socket()); 152 EXPECT_FALSE(handle.socket());
153 153
154 EXPECT_EQ(ERR_PROXY_CONNECTION_FAILED, callback.WaitForResult()); 154 EXPECT_EQ(ERR_PROXY_CONNECTION_FAILED, callback.WaitForResult());
155 EXPECT_FALSE(handle.is_initialized()); 155 EXPECT_FALSE(handle.is_initialized());
156 EXPECT_FALSE(handle.socket()); 156 EXPECT_FALSE(handle.socket());
157 } 157 }
158 158
159 TEST_F(SOCKSClientSocketPoolTest, SOCKSConnectError) { 159 TEST_F(SOCKSClientSocketPoolTest, SOCKSConnectError) {
160 MockRead failed_read[] = { 160 MockRead failed_read[] = {
161 MockRead(false, 0), 161 MockRead(false, 0),
162 }; 162 };
163 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider( 163 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider(
164 failed_read, arraysize(failed_read), NULL, 0)); 164 failed_read, arraysize(failed_read), NULL, 0));
165 socket_data->set_connect_data(MockConnect(false, 0)); 165 socket_data->set_connect_data(MockConnect(false, 0));
166 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get()); 166 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
167 167
168 ClientSocketHandle handle; 168 ClientSocketHandle handle;
169 EXPECT_EQ(0, transport_socket_pool_.release_count()); 169 EXPECT_EQ(0, transport_socket_pool_.release_count());
170 int rv = handle.Init("a", ignored_socket_params_, LOW, NULL, &pool_, 170 int rv = handle.Init("a", ignored_socket_params_, LOW, CompletionCallback(),
171 BoundNetLog()); 171 &pool_, BoundNetLog());
172 EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, rv); 172 EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, rv);
173 EXPECT_FALSE(handle.is_initialized()); 173 EXPECT_FALSE(handle.is_initialized());
174 EXPECT_FALSE(handle.socket()); 174 EXPECT_FALSE(handle.socket());
175 EXPECT_EQ(1, transport_socket_pool_.release_count()); 175 EXPECT_EQ(1, transport_socket_pool_.release_count());
176 } 176 }
177 177
178 TEST_F(SOCKSClientSocketPoolTest, AsyncSOCKSConnectError) { 178 TEST_F(SOCKSClientSocketPoolTest, AsyncSOCKSConnectError) {
179 MockRead failed_read[] = { 179 MockRead failed_read[] = {
180 MockRead(true, 0), 180 MockRead(true, 0),
181 }; 181 };
182 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider( 182 scoped_ptr<SocketDataProvider> socket_data(new StaticSocketDataProvider(
183 failed_read, arraysize(failed_read), NULL, 0)); 183 failed_read, arraysize(failed_read), NULL, 0));
184 socket_data->set_connect_data(MockConnect(false, 0)); 184 socket_data->set_connect_data(MockConnect(false, 0));
185 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get()); 185 transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
186 186
187 TestOldCompletionCallback callback; 187 TestCompletionCallback callback;
188 ClientSocketHandle handle; 188 ClientSocketHandle handle;
189 EXPECT_EQ(0, transport_socket_pool_.release_count()); 189 EXPECT_EQ(0, transport_socket_pool_.release_count());
190 int rv = handle.Init("a", ignored_socket_params_, LOW, &callback, &pool_, 190 int rv = handle.Init("a", ignored_socket_params_, LOW, callback.callback(),
191 BoundNetLog()); 191 &pool_, BoundNetLog());
192 EXPECT_EQ(ERR_IO_PENDING, rv); 192 EXPECT_EQ(ERR_IO_PENDING, rv);
193 EXPECT_FALSE(handle.is_initialized()); 193 EXPECT_FALSE(handle.is_initialized());
194 EXPECT_FALSE(handle.socket()); 194 EXPECT_FALSE(handle.socket());
195 195
196 EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, callback.WaitForResult()); 196 EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, callback.WaitForResult());
197 EXPECT_FALSE(handle.is_initialized()); 197 EXPECT_FALSE(handle.is_initialized());
198 EXPECT_FALSE(handle.socket()); 198 EXPECT_FALSE(handle.socket());
199 EXPECT_EQ(1, transport_socket_pool_.release_count()); 199 EXPECT_EQ(1, transport_socket_pool_.release_count());
200 } 200 }
201 201
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 266
267 (*requests())[0]->handle()->Reset(); 267 (*requests())[0]->handle()->Reset();
268 (*requests())[1]->handle()->Reset(); 268 (*requests())[1]->handle()->Reset();
269 } 269 }
270 270
271 // It would be nice to also test the timeouts in SOCKSClientSocketPool. 271 // It would be nice to also test the timeouts in SOCKSClientSocketPool.
272 272
273 } // namespace 273 } // namespace
274 274
275 } // namespace net 275 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/socks_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698