Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: jingle/notifier/base/proxy_resolving_client_socket.cc

Issue 8898036: base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Possible test fix. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « jingle/notifier/base/proxy_resolving_client_socket.h ('k') | net/base/test_completion_callback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jingle/notifier/base/proxy_resolving_client_socket.cc
diff --git a/jingle/notifier/base/proxy_resolving_client_socket.cc b/jingle/notifier/base/proxy_resolving_client_socket.cc
index 6314bb28170028fafe8fe0d234b73ce3833b3094..6b6341a29fc929f10d4486219bedc3c7d62f8c12 100644
--- a/jingle/notifier/base/proxy_resolving_client_socket.cc
+++ b/jingle/notifier/base/proxy_resolving_client_socket.cc
@@ -6,6 +6,7 @@
#include "base/basictypes.h"
#include "base/bind.h"
+#include "base/bind_helpers.h"
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "googleurl/src/gurl.h"
@@ -24,10 +25,12 @@ ProxyResolvingClientSocket::ProxyResolvingClientSocket(
const scoped_refptr<net::URLRequestContextGetter>& request_context_getter,
const net::SSLConfig& ssl_config,
const net::HostPortPair& dest_host_port_pair)
- : proxy_resolve_callback_(ALLOW_THIS_IN_INITIALIZER_LIST(this),
- &ProxyResolvingClientSocket::ProcessProxyResolveDone),
- connect_callback_(ALLOW_THIS_IN_INITIALIZER_LIST(this),
- &ProxyResolvingClientSocket::ProcessConnectDone),
+ : ALLOW_THIS_IN_INITIALIZER_LIST(proxy_resolve_callback_(
+ base::Bind(&ProxyResolvingClientSocket::ProcessProxyResolveDone,
+ base::Unretained(this)))),
+ ALLOW_THIS_IN_INITIALIZER_LIST(connect_callback_(
+ base::Bind(&ProxyResolvingClientSocket::ProcessConnectDone,
+ base::Unretained(this)))),
ssl_config_(ssl_config),
pac_request_(NULL),
dest_host_port_pair_(dest_host_port_pair),
@@ -109,7 +112,7 @@ int ProxyResolvingClientSocket::Connect(
int status = network_session_->proxy_service()->ResolveProxy(
url,
&proxy_info_,
- &proxy_resolve_callback_,
+ proxy_resolve_callback_,
&pac_request_,
bound_net_log_);
if (status != net::ERR_IO_PENDING) {
@@ -169,14 +172,8 @@ void ProxyResolvingClientSocket::ProcessProxyResolveDone(int status) {
transport_.reset(new net::ClientSocketHandle);
// Now that we have resolved the proxy, we need to connect.
status = net::InitSocketHandleForRawConnect(
- dest_host_port_pair_,
- network_session_.get(),
- proxy_info_,
- ssl_config_,
- ssl_config_,
- bound_net_log_,
- transport_.get(),
- &connect_callback_);
+ dest_host_port_pair_, network_session_.get(), proxy_info_, ssl_config_,
+ ssl_config_, bound_net_log_, transport_.get(), connect_callback_);
if (status != net::ERR_IO_PENDING) {
// Since this method is always called asynchronously. it is OK to call
// ProcessConnectDone synchronously.
@@ -254,7 +251,7 @@ int ProxyResolvingClientSocket::ReconsiderProxyAfterError(int error) {
GURL url("http://" + dest_host_port_pair_.ToString());
int rv = network_session_->proxy_service()->ReconsiderProxyAfterError(
- url, &proxy_info_, &proxy_resolve_callback_, &pac_request_,
+ url, &proxy_info_, proxy_resolve_callback_, &pac_request_,
bound_net_log_);
if (rv == net::OK || rv == net::ERR_IO_PENDING) {
CloseTransportSocket();
« no previous file with comments | « jingle/notifier/base/proxy_resolving_client_socket.h ('k') | net/base/test_completion_callback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698