Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: net/socket/socks_client_socket_pool_unittest.cc

Issue 8898036: base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Possible test fix. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socks_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socks_client_socket_pool_unittest.cc
diff --git a/net/socket/socks_client_socket_pool_unittest.cc b/net/socket/socks_client_socket_pool_unittest.cc
index 148cb5bd2dd1be9c40d4244e9aa4ef77b87076d6..28706eae48b31ba9886e9cf4f86fc18d4f6f74e4 100644
--- a/net/socket/socks_client_socket_pool_unittest.cc
+++ b/net/socket/socks_client_socket_pool_unittest.cc
@@ -101,8 +101,8 @@ TEST_F(SOCKSClientSocketPoolTest, Simple) {
transport_client_socket_factory_.AddSocketDataProvider(data.data_provider());
ClientSocketHandle handle;
- int rv = handle.Init("a", ignored_socket_params_, LOW, NULL, &pool_,
- BoundNetLog());
+ int rv = handle.Init("a", ignored_socket_params_, LOW, CompletionCallback(),
+ &pool_, BoundNetLog());
EXPECT_EQ(OK, rv);
EXPECT_TRUE(handle.is_initialized());
EXPECT_TRUE(handle.socket());
@@ -112,10 +112,10 @@ TEST_F(SOCKSClientSocketPoolTest, Async) {
SOCKS5MockData data(true);
transport_client_socket_factory_.AddSocketDataProvider(data.data_provider());
- TestOldCompletionCallback callback;
+ TestCompletionCallback callback;
ClientSocketHandle handle;
- int rv = handle.Init("a", ignored_socket_params_, LOW, &callback, &pool_,
- BoundNetLog());
+ int rv = handle.Init("a", ignored_socket_params_, LOW, callback.callback(),
+ &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle.is_initialized());
EXPECT_FALSE(handle.socket());
@@ -131,8 +131,8 @@ TEST_F(SOCKSClientSocketPoolTest, TransportConnectError) {
transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
ClientSocketHandle handle;
- int rv = handle.Init("a", ignored_socket_params_, LOW, NULL, &pool_,
- BoundNetLog());
+ int rv = handle.Init("a", ignored_socket_params_, LOW, CompletionCallback(),
+ &pool_, BoundNetLog());
EXPECT_EQ(ERR_PROXY_CONNECTION_FAILED, rv);
EXPECT_FALSE(handle.is_initialized());
EXPECT_FALSE(handle.socket());
@@ -143,10 +143,10 @@ TEST_F(SOCKSClientSocketPoolTest, AsyncTransportConnectError) {
socket_data->set_connect_data(MockConnect(true, ERR_CONNECTION_REFUSED));
transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
- TestOldCompletionCallback callback;
+ TestCompletionCallback callback;
ClientSocketHandle handle;
- int rv = handle.Init("a", ignored_socket_params_, LOW, &callback, &pool_,
- BoundNetLog());
+ int rv = handle.Init("a", ignored_socket_params_, LOW, callback.callback(),
+ &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle.is_initialized());
EXPECT_FALSE(handle.socket());
@@ -167,8 +167,8 @@ TEST_F(SOCKSClientSocketPoolTest, SOCKSConnectError) {
ClientSocketHandle handle;
EXPECT_EQ(0, transport_socket_pool_.release_count());
- int rv = handle.Init("a", ignored_socket_params_, LOW, NULL, &pool_,
- BoundNetLog());
+ int rv = handle.Init("a", ignored_socket_params_, LOW, CompletionCallback(),
+ &pool_, BoundNetLog());
EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, rv);
EXPECT_FALSE(handle.is_initialized());
EXPECT_FALSE(handle.socket());
@@ -184,11 +184,11 @@ TEST_F(SOCKSClientSocketPoolTest, AsyncSOCKSConnectError) {
socket_data->set_connect_data(MockConnect(false, 0));
transport_client_socket_factory_.AddSocketDataProvider(socket_data.get());
- TestOldCompletionCallback callback;
+ TestCompletionCallback callback;
ClientSocketHandle handle;
EXPECT_EQ(0, transport_socket_pool_.release_count());
- int rv = handle.Init("a", ignored_socket_params_, LOW, &callback, &pool_,
- BoundNetLog());
+ int rv = handle.Init("a", ignored_socket_params_, LOW, callback.callback(),
+ &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle.is_initialized());
EXPECT_FALSE(handle.socket());
« no previous file with comments | « net/socket/socks_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698