Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8892011: Clean up TCW, make it solely a hub for 1:1 observer/helper objects. (Closed)

Created:
9 years ago by Avi (use Gerrit)
Modified:
9 years ago
Reviewers:
Jói
CC:
chromium-reviews, vrk (LEFT CHROMIUM), nkostylev+watch_chromium.org, acolwell+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, GeorgeY, cbentzel+watch_chromium.org, Ilya Sherman, kkania, brettw-cc_chromium.org, ihf+watch_chromium.org, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dyu1, ddorwin+watch_chromium.org, fischman+watch_chromium.org, annacc+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, davemoore+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., James Su, mmenke
Visibility:
Public.

Description

Clean up TCW, make it solely a hub for 1:1 observer/helper objects. BUG=105872 TEST=no functional change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -321 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_application_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock_window_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 14 chunks +31 lines, -22 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_id_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 11 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 12 chunks +35 lines, -23 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager_delegate_impl.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 8 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sessions/restore_tab_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 9 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_order_controller.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/alternate_error_tab_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 17 chunks +31 lines, -19 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_list_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 13 chunks +23 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/fullscreen_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/drag_data.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 14 chunks +18 lines, -13 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 7 chunks +13 lines, -18 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Yeah, this grew a bit too much. The real change is in TCW; all the ...
9 years ago (2011-12-09 20:59:41 UTC) #1
Jói
9 years ago (2011-12-09 21:09:05 UTC) #2 
LGTM

Nice!

If you find you need further patches on this review that you need me to look at,
please remember to upload before and after each merge so that I have deltas
representing the "real" work.

Cheers,
Jói

Powered by Google App Engine
This is Rietveld 408576698