Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 8892011: Clean up TCW, make it solely a hub for 1:1 observer/helper objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/process_util.h" 5 #include "base/process_util.h"
6 #include "chrome/browser/browser_process.h" 6 #include "chrome/browser/browser_process.h"
7 #include "chrome/browser/extensions/extension_browsertest.h" 7 #include "chrome/browser/extensions/extension_browsertest.h"
8 #include "chrome/browser/extensions/extension_host.h" 8 #include "chrome/browser/extensions/extension_host.h"
9 #include "chrome/browser/extensions/extension_process_manager.h" 9 #include "chrome/browser/extensions/extension_process_manager.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 // Tab should still be open, and extension should be crashed. 465 // Tab should still be open, and extension should be crashed.
466 EXPECT_EQ(tabs_before, tab_strip->count()); 466 EXPECT_EQ(tabs_before, tab_strip->count());
467 EXPECT_EQ(size_before, GetExtensionService()->extensions()->size()); 467 EXPECT_EQ(size_before, GetExtensionService()->extensions()->size());
468 EXPECT_EQ(crash_size_before + 1, 468 EXPECT_EQ(crash_size_before + 1,
469 GetExtensionService()->terminated_extensions()->size()); 469 GetExtensionService()->terminated_extensions()->size());
470 470
471 { 471 {
472 ui_test_utils::WindowedNotificationObserver observer( 472 ui_test_utils::WindowedNotificationObserver observer(
473 content::NOTIFICATION_LOAD_STOP, 473 content::NOTIFICATION_LOAD_STOP,
474 content::Source<NavigationController>( 474 content::Source<NavigationController>(
475 &browser()->GetSelectedTabContentsWrapper()->controller())); 475 &browser()->GetSelectedTabContentsWrapper()->tab_contents()->
476 controller()));
476 browser()->Reload(CURRENT_TAB); 477 browser()->Reload(CURRENT_TAB);
477 observer.Wait(); 478 observer.Wait();
478 } 479 }
479 // Extension should now be loaded. 480 // Extension should now be loaded.
480 SCOPED_TRACE("after reloading the tab"); 481 SCOPED_TRACE("after reloading the tab");
481 CheckExtensionConsistency(first_extension_id_); 482 CheckExtensionConsistency(first_extension_id_);
482 ASSERT_EQ(size_before + 1, GetExtensionService()->extensions()->size()); 483 ASSERT_EQ(size_before + 1, GetExtensionService()->extensions()->size());
483 ASSERT_EQ(0U, CountBalloons()); 484 ASSERT_EQ(0U, CountBalloons());
484 } 485 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_browsertests_misc.cc ('k') | chrome/browser/extensions/extension_devtools_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698