Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: chrome/browser/ui/webui/web_ui_browsertest.cc

Issue 8892011: Clean up TCW, make it solely a hub for 1:1 observer/helper objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "chrome/browser/ui/webui/web_ui_browsertest.h" 4 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
5 5
6 #include <string> 6 #include <string>
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 args.push_back(Value::CreateStringValue(preload_test_fixture)); 171 args.push_back(Value::CreateStringValue(preload_test_fixture));
172 args.push_back(Value::CreateStringValue(preload_test_name)); 172 args.push_back(Value::CreateStringValue(preload_test_name));
173 RunJavascriptUsingHandler( 173 RunJavascriptUsingHandler(
174 "preloadJavascriptLibraries", args, false, false, preload_host); 174 "preloadJavascriptLibraries", args, false, false, preload_host);
175 libraries_preloaded_ = true; 175 libraries_preloaded_ = true;
176 } 176 }
177 177
178 void WebUIBrowserTest::BrowsePreload(const GURL& browse_to) { 178 void WebUIBrowserTest::BrowsePreload(const GURL& browse_to) {
179 TestNavigationObserver navigation_observer( 179 TestNavigationObserver navigation_observer(
180 content::Source<NavigationController>( 180 content::Source<NavigationController>(
181 &browser()->GetSelectedTabContentsWrapper()->controller()), 181 &browser()->GetSelectedTabContentsWrapper()->tab_contents()->
182 controller()),
182 this, 1); 183 this, 1);
183 browser::NavigateParams params( 184 browser::NavigateParams params(
184 browser(), GURL(browse_to), content::PAGE_TRANSITION_TYPED); 185 browser(), GURL(browse_to), content::PAGE_TRANSITION_TYPED);
185 params.disposition = CURRENT_TAB; 186 params.disposition = CURRENT_TAB;
186 browser::Navigate(&params); 187 browser::Navigate(&params);
187 navigation_observer.WaitForObservation(); 188 navigation_observer.WaitForObservation();
188 } 189 }
189 190
190 void WebUIBrowserTest::BrowsePrintPreload(const GURL& browse_to) { 191 void WebUIBrowserTest::BrowsePrintPreload(const GURL& browse_to) {
191 ui_test_utils::NavigateToURL(browser(), browse_to); 192 ui_test_utils::NavigateToURL(browser(), browse_to);
192 193
193 TestTabStripModelObserver tabstrip_observer( 194 TestTabStripModelObserver tabstrip_observer(
194 browser()->tabstrip_model(), this); 195 browser()->tabstrip_model(), this);
195 browser()->Print(); 196 browser()->Print();
196 tabstrip_observer.WaitForObservation(); 197 tabstrip_observer.WaitForObservation();
197 printing::PrintPreviewTabController* tab_controller = 198 printing::PrintPreviewTabController* tab_controller =
198 printing::PrintPreviewTabController::GetInstance(); 199 printing::PrintPreviewTabController::GetInstance();
199 ASSERT_TRUE(tab_controller); 200 ASSERT_TRUE(tab_controller);
200 TabContentsWrapper* preview_tab = tab_controller->GetPrintPreviewForTab( 201 TabContentsWrapper* preview_tab = tab_controller->GetPrintPreviewForTab(
201 browser()->GetSelectedTabContentsWrapper()); 202 browser()->GetSelectedTabContentsWrapper());
202 ASSERT_TRUE(preview_tab); 203 ASSERT_TRUE(preview_tab);
203 SetWebUIInstance(preview_tab->web_ui()); 204 SetWebUIInstance(preview_tab->tab_contents()->web_ui());
204 } 205 }
205 206
206 const char WebUIBrowserTest::kDummyURL[] = "chrome://DummyURL"; 207 const char WebUIBrowserTest::kDummyURL[] = "chrome://DummyURL";
207 208
208 WebUIBrowserTest::WebUIBrowserTest() 209 WebUIBrowserTest::WebUIBrowserTest()
209 : test_handler_(new WebUITestHandler()), 210 : test_handler_(new WebUITestHandler()),
210 libraries_preloaded_(false), 211 libraries_preloaded_(false),
211 override_selected_web_ui_(NULL) {} 212 override_selected_web_ui_(NULL) {}
212 213
213 void WebUIBrowserTest::set_preload_test_fixture( 214 void WebUIBrowserTest::set_preload_test_fixture(
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 // testDone directly and expect pass result. 626 // testDone directly and expect pass result.
626 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPassesAsync) { 627 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPassesAsync) {
627 ASSERT_TRUE(RunJavascriptAsyncTest("testDone")); 628 ASSERT_TRUE(RunJavascriptAsyncTest("testDone"));
628 } 629 }
629 630
630 // Test that calling testDone during RunJavascriptTest still completes when 631 // Test that calling testDone during RunJavascriptTest still completes when
631 // waiting for async result. 632 // waiting for async result.
632 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPasses) { 633 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPasses) {
633 ASSERT_TRUE(RunJavascriptTest("testDone")); 634 ASSERT_TRUE(RunJavascriptTest("testDone"));
634 } 635 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_ui.cc ('k') | chrome/test/base/browser_with_test_window_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698