chrome/browser/crash_recovery_browsertest.cc - Issue 8892011: Clean up TCW, make it solely a hub for 1:1 observer/helper objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/crash_recovery_browsertest.cc

Issue 8892011: Clean up TCW, make it solely a hub for 1:1 observer/helper objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_browsertest.cc ('k') | chrome/browser/debugger/devtools_sanity_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/crash_recovery_browsertest.cc

diff --git a/chrome/browser/crash_recovery_browsertest.cc b/chrome/browser/crash_recovery_browsertest.cc

index 0bbb48506136fe03afb46517b89a4cf7168c4589..3d644a3ee2dee19b8d391305926bbffcc1c7787e 100644

--- a/chrome/browser/crash_recovery_browsertest.cc

+++ b/chrome/browser/crash_recovery_browsertest.cc

@@ -9,6 +9,7 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/browser/tab_contents/navigation_entry.h"

+#include "content/browser/tab_contents/tab_contents.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

#include "content/public/common/page_transition_types.h"

@@ -31,7 +32,7 @@ class CrashRecoveryBrowserTest : public InProcessBrowserTest {

};

// Test that reload works after a crash.

-// Disabled, http://crbug.com/29331, http://crbug.com/69637.

+// Disabled, http://crbug.com/29331 , http://crbug.com/69637 .

IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, Reload) {

// The title of the active tab should change each time this URL is loaded.

GURL url(

@@ -47,7 +48,8 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, Reload) {

ui_test_utils::WindowedNotificationObserver observer(

content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

- &browser()->GetSelectedTabContentsWrapper()->controller()));

+ &browser()->GetSelectedTabContentsWrapper()->tab_contents()->

+ controller()));

browser()->Reload(CURRENT_TAB);

observer.Wait();

ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),

@@ -76,7 +78,8 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, LoadInNewTab) {