Make check for 'opened' consistent across all audio stream implementations of Start() and log an ...

Make check for 'opened' consistent across all audio stream implementations of Start() and log an error if open hasn't been called successfully.
This fixes

BUG=106712
TEST=Run media_unittests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113679

[henrika (OOO until Aug 14), 2011-12-08 20:30:35]

LGTM with one comment which spans all files.

[henrika (OOO until Aug 14), 2011-12-08 20:30:47]

http://codereview.chromium.org/8872028/diff/1/media/audio/mac/audio_low_laten...
File media/audio/mac/audio_low_latency_output_mac.cc (right):

http://codereview.chromium.org/8872028/diff/1/media/audio/mac/audio_low_laten...
media/audio/mac/audio_low_latency_output_mac.cc:178: DLOG_IF(ERROR,
!output_unit_) << "Must call Open() first";
Can we make the error message also reflect the fact that Open() might have
failed? I mean the user might have called Open() and we log "you have not called
Open()".

[tommi (sloooow) - chröme, 2011-12-08 20:47:01]

http://codereview.chromium.org/8872028/diff/1/media/audio/mac/audio_low_laten...
File media/audio/mac/audio_low_latency_output_mac.cc (right):

http://codereview.chromium.org/8872028/diff/1/media/audio/mac/audio_low_laten...
media/audio/mac/audio_low_latency_output_mac.cc:178: DLOG_IF(ERROR,
!output_unit_) << "Must call Open() first";
On 2011/12/08 20:30:47, henrika1 wrote:
> Can we make the error message also reflect the fact that Open() might have
> failed? I mean the user might have called Open() and we log "you have not
called
> Open()".

good point.  Changed all occurrences to "Open() has not been called
successfully".

[commit-bot: I haz the power, 2011-12-08 20:47:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommi@chromium.org/8872028/3002

[commit-bot: I haz the power, 2011-12-08 22:34:07]

Change committed as 113679