Make check for 'opened' consistent across all audio stream implementations of Start() and log an ...

media/audio/pulse/pulse_output.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/pulse/pulse_output.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "media/audio/audio_parameters.h"
 #include "media/audio/audio_util.h"
@@ skipping 365 matching lines @@
     // Write data to stream.
     pa_stream_write(playback_handle_, chunk, chunk_size,
                     NULL, 0LL, PA_SEEK_RELATIVE);
     client_buffer_->Seek(chunk_size);
     *bytes_written += chunk_size;
   }
 }
 
 void PulseAudioOutputStream::Start(AudioSourceCallback* callback) {
   DCHECK_EQ(message_loop_, MessageLoop::current());
+  CHECK(callback);
+  DLOG_IF(ERROR, !playback_handle_)
+      << "Open() has not been called successfully";
+  if (!playback_handle_)
+    return;
 
-  CHECK(callback);
   source_callback_ = callback;
 
   // Clear buffer, it might still have data in it.
   client_buffer_->Clear();
   stream_stopped_ = false;
 
   // Start playback.
   message_loop_->PostTask(FROM_HERE, base::Bind(
       &PulseAudioOutputStream::WaitForWriteRequest,
       weak_factory_.GetWeakPtr()));
@@ skipping 17 matching lines @@
   *volume = volume_;
 }
 
 uint32 PulseAudioOutputStream::RunDataCallback(
     uint8* dest, uint32 max_size, AudioBuffersState buffers_state) {
   if (source_callback_)
     return source_callback_->OnMoreData(this, dest, max_size, buffers_state);
 
   return 0;
 }