Make check for 'opened' consistent across all audio stream implementations of Start() and log an ...

media/audio/mac/audio_input_mac.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/mac/audio_input_mac.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "media/audio/audio_util.h"
 #include "media/audio/mac/audio_manager_mac.h"
@@ skipping 45 matching lines @@
                                     &audio_queue_);
   if (err != noErr) {
     HandleError(err);
     return false;
   }
   return SetupBuffers();
 }
 
 void PCMQueueInAudioInputStream::Start(AudioInputCallback* callback) {
   DCHECK(callback);
-  DCHECK(audio_queue_) << "Must call Open() first";
-  if (callback_)
+  DLOG_IF(ERROR, !audio_queue_) << "Open() has not been called successfully";
+  if (callback_ || !audio_queue_)
     return;
   callback_ = callback;
   OSStatus err = AudioQueueStart(audio_queue_, NULL);
   if (err != noErr)
     HandleError(err);
   else
     manager_->IncreaseActiveInputStreamCount();
 }
 
 void PCMQueueInAudioInputStream::Stop() {
@@ skipping 99 matching lines @@
       // TODO(joth): PCMQueueOutAudioOutputStream uses callback_ to provide an
       // extra guard for this situation, but it seems to introduce more
       // complications than it solves (memory barrier issues accessing it from
       // multiple threads, looses the means to indicate OnClosed to client).
       // Should determine if we need to do something equivalent here.
       return;
     }
     HandleError(err);
   }
 }