media/audio/pulse/pulse_output.cc - Issue 8872028: Make check for 'opened' consistent across all audio stream implementations of Start() and log an ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/pulse/pulse_output.cc

Issue 8872028: Make check for 'opened' consistent across all audio stream implementations of Start() and log an ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/pulse/pulse_output.cc

===================================================================

--- media/audio/pulse/pulse_output.cc (revision 113210)

+++ media/audio/pulse/pulse_output.cc (working copy)

@@ -383,8 +383,12 @@

void PulseAudioOutputStream::Start(AudioSourceCallback* callback) {

DCHECK_EQ(message_loop_, MessageLoop::current());

+ CHECK(callback);

+ DLOG_IF(ERROR, !playback_handle_)

+ << "Open() has not been called successfully";

+ if (!playback_handle_)

+ return;

- CHECK(callback);

source_callback_ = callback;

// Clear buffer, it might still have data in it.

« no previous file with comments | « media/audio/mac/audio_output_mac.cc ('k') | media/audio/win/audio_low_latency_input_win.cc » ('j') | no next file with comments »