Fix alignment of avatar bubbles in the NTP

Fix alignment of avatar bubbles in the NTP

BUG=105014
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113636

[sail, 2011-12-08 00:27:00]

satish: speech OWNERS review
sky: ui/views, browser/ui/views OWNERS review

[msw, 2011-12-08 00:40:14]

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/bookma...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/bookma...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:126: rect.Offset(0,
-5);
Please change this to rect.Inset(5, 5); Thanks!

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/conten...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/conten...
chrome/browser/ui/views/content_setting_bubble_contents.cc:138: rect.Offset(0,
-5);
Please change this to rect.Inset(5, 5);? Thanks!

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/first_...
File chrome/browser/ui/views/first_run_bubble.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/first_...
chrome/browser/ui/views/first_run_bubble.cc:103: rect.Offset(0, anchor_view() ?
kAnchorVerticalOffset : 0);
Please change this to:
rect.Inset(0, anchor_view() ? -kAnchorVerticalOffset : 0);
(optionally rename const to kAnchorVerticalInset, make that positive and drop
the negative operator here) Thanks!

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/frame/...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/frame/...
chrome/browser/ui/views/frame/browser_view.cc:2636: // TODO(msw): Set and
support views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
PLease remove TODO if this CL gets the job done; thanks!

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/global...
File chrome/browser/ui/views/global_error_bubble_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/global...
chrome/browser/ui/views/global_error_bubble_view.cc:129: rect.Offset(0,
anchor_view() ? kWrenchBubblePointOffsetY : 0);
Please change this to:
rect.Inset(0, anchor_view() ? -kWrenchBubblePointOffsetY : 0);
(optionally rename const to kWrenchBubblePointInsetY, make that positive and
drop the negative operator here) Thanks!

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/page_i...
File chrome/browser/ui/views/page_info_bubble_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/page_i...
chrome/browser/ui/views/page_info_bubble_view.cc:305: anchor.Offset(0, -5);
Please change this to rect.Inset(5, 5); Thanks!

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_delegat...
File ui/views/bubble/bubble_delegate.cc (right):

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_delegat...
ui/views/bubble/bubble_delegate.cc:222:
views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE);
Pass along alignment, not this hard-coded value.

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
File ui/views/bubble/bubble_frame_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
ui/views/bubble/bubble_frame_view.cc:57: const gfx::Rect& anchor, const
gfx::Size& client_size) const {
Put params on independent lines.

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
File ui/views/bubble/bubble_frame_view.h (right):

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
ui/views/bubble/bubble_frame_view.h:45: const gfx::Rect& anchor, const
gfx::Size& client_size) const;
Put params on independent lines.

[sail, 2011-12-08 01:41:10]

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/bookma...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/bookma...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:126: rect.Offset(0,
-5);
On 2011/12/08 00:40:14, msw wrote:
> Please change this to rect.Inset(5, 5); Thanks!

Unfortunately Inset() doesn't do the right thing since this is a 0x0 rect. Same
below.

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/frame/...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/frame/...
chrome/browser/ui/views/frame/browser_view.cc:2636: // TODO(msw): Set and
support views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
On 2011/12/08 00:40:14, msw wrote:
> PLease remove TODO if this CL gets the job done; thanks!

Done.

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_delegat...
File ui/views/bubble/bubble_delegate.cc (right):

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_delegat...
ui/views/bubble/bubble_delegate.cc:222:
views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE);
On 2011/12/08 00:40:14, msw wrote:
> Pass along alignment, not this hard-coded value.

Done.

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
File ui/views/bubble/bubble_frame_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
ui/views/bubble/bubble_frame_view.cc:57: const gfx::Rect& anchor, const
gfx::Size& client_size) const {
On 2011/12/08 00:40:14, msw wrote:
> Put params on independent lines.

Done.

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
File ui/views/bubble/bubble_frame_view.h (right):

http://codereview.chromium.org/8863009/diff/26/ui/views/bubble/bubble_frame_v...
ui/views/bubble/bubble_frame_view.h:45: const gfx::Rect& anchor, const
gfx::Size& client_size) const;
On 2011/12/08 00:40:14, msw wrote:
> Put params on independent lines.

Done.

[msw, 2011-12-08 06:26:41]

LGTM, thanks for fixing this up.

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/bookma...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

http://codereview.chromium.org/8863009/diff/26/chrome/browser/ui/views/bookma...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:126: rect.Offset(0,
-5);
On 2011/12/08 01:41:10, sail wrote:
> On 2011/12/08 00:40:14, msw wrote:
> > Please change this to rect.Inset(5, 5); Thanks!
> 
> Unfortunately Inset() doesn't do the right thing since this is a 0x0 rect.
Same
> below.

Bummer! okay, I'll fix it later.

[commit-bot: I haz the power, 2011-12-08 06:32:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8863009/7005

[commit-bot: I haz the power, 2011-12-08 06:32:51]

Can't apply patch for file chrome/browser/ui/views/frame/browser_view.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/views/frame/browser_view.cc
Hunk #1 FAILED at 2633.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/views/frame/browser_view.cc.rej

[sky, 2011-12-08 17:07:35]

Rubber stamp LGTM from me. I'll hit the commit button again for you.

[commit-bot: I haz the power, 2011-12-08 17:08:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8863009/9025

[commit-bot: I haz the power, 2011-12-08 19:00:00]

Change committed as 113636