Fix alignment of avatar bubbles in the NTP

chrome/browser/ui/views/global_error_bubble_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/global_error_bubble_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/global_error.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/toolbar_view.h"
@@ skipping 106 matching lines @@
   if (cancel_button.get())
     layout->AddView(cancel_button.release());
 
   // Adjust the message label size in case buttons are too long.
   message_label->SizeToFit(layout->GetPreferredSize(this).width());
 }
 
 GlobalErrorBubbleView::~GlobalErrorBubbleView() {
 }
 
-gfx::Point GlobalErrorBubbleView::GetAnchorPoint() {
-  return (views::BubbleDelegateView::GetAnchorPoint().Add(
-      gfx::Point(0, anchor_view() ? kWrenchBubblePointOffsetY : 0)));
+gfx::Rect GlobalErrorBubbleView::GetAnchorRect() {
+  gfx::Rect rect(views::BubbleDelegateView::GetAnchorRect());
+  rect.Offset(0, anchor_view() ? kWrenchBubblePointOffsetY : 0);

[msw, 2011/12/08 00:40:14]

Please change this to:
rect.Inset(0, anchor_view() ? -kWrenchBubblePointOffsetY : 0);
(optionally rename const to kWrenchBubblePointInsetY, make that positive and
drop the negative operator here) Thanks!

+  return rect;
 }
 
 void GlobalErrorBubbleView::ButtonPressed(views::Button* sender,
                                           const views::Event& event) {
   if (sender->tag() == TAG_ACCEPT_BUTTON)
     error_->BubbleViewAcceptButtonPressed();
   else if (sender->tag() == TAG_CANCEL_BUTTON)
     error_->BubbleViewCancelButtonPressed();
   else
     NOTREACHED();
   GetWidget()->Close();
 }
 
 void GlobalErrorBubbleView::WindowClosing() {
   error_->BubbleViewDidClose();
 }
 
 void GlobalError::ShowBubbleView(Browser* browser, GlobalError* error) {
   BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
   views::View* wrench_button = browser_view->toolbar()->app_menu();
   GlobalErrorBubbleView* bubble_view =
       new GlobalErrorBubbleView(wrench_button,
                                 views::BubbleBorder::TOP_RIGHT,
                                 SK_ColorWHITE,
                                 browser,
                                 error);
   browser::CreateViewsBubble(bubble_view);
   bubble_view->StartFade(true);
 }