Fix alignment of avatar bubbles in the NTP

chrome/browser/ui/views/first_run_bubble.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/first_run_bubble.h"
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/search_engines/util.h"
@@ skipping 79 matching lines @@
   layout->StartRow(0, 0);
   layout->AddView(label1);
   layout->AddView(close_button, 1, 1, views::GridLayout::TRAILING,
                   views::GridLayout::LEADING);
   layout->AddPaddingRow(0, views::kRelatedControlSmallVerticalSpacing);
 
   layout->StartRow(0, 0);
   layout->AddView(label2);
 }
 
-gfx::Point FirstRunBubble::GetAnchorPoint() {
+gfx::Rect FirstRunBubble::GetAnchorRect() {
   // Compensate for padding in anchor.
-  return BubbleDelegateView::GetAnchorPoint().Add(
-      gfx::Point(0, anchor_view() ? kAnchorVerticalOffset : 0));
+  gfx::Rect rect(BubbleDelegateView::GetAnchorRect());
+  rect.Offset(0, anchor_view() ? kAnchorVerticalOffset : 0);

[msw, 2011/12/08 00:40:14]

Please change this to:
rect.Inset(0, anchor_view() ? -kAnchorVerticalOffset : 0);
(optionally rename const to kAnchorVerticalInset, make that positive and drop
the negative operator here) Thanks!

+  return rect;
 }
 
 FirstRunBubble::FirstRunBubble(
     Profile* profile,
     views::View* anchor_view,
     views::BubbleBorder::ArrowLocation arrow_location,
     FirstRun::BubbleType bubble_type)
     : views::BubbleDelegateView(anchor_view,
                                 arrow_location,
                                 SK_ColorWHITE),
       profile_(profile),
       bubble_type_(bubble_type) {
 }
 
 FirstRunBubble::~FirstRunBubble() {
 }
 
 void FirstRunBubble::ButtonPressed(views::Button* sender,
                                    const views::Event& event) {
   if (bubble_type_ == FirstRun::OEM_BUBBLE) {
     UserMetrics::RecordAction(
         UserMetricsAction("FirstRunOEMBubbleView_Clicked"));
   }
   GetWidget()->Close();
 }