Fix alignment of avatar bubbles in the NTP

chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
 
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 102 matching lines @@
     const BookmarkNode* node = model->GetMostRecentlyAddedNodeForURL(url_);
     if (node)
       model->Remove(node->parent(), node->parent()->GetIndexOf(node));
   }
 }
 
 views::View* BookmarkBubbleView::GetInitiallyFocusedView() {
   return title_tf_;
 }
 
-gfx::Point BookmarkBubbleView::GetAnchorPoint() {
+gfx::Rect BookmarkBubbleView::GetAnchorRect() {
   // Compensate for some built-in padding in the star image.
-  return BubbleDelegateView::GetAnchorPoint().Subtract(gfx::Point(0, 5));
+  gfx::Rect rect(BubbleDelegateView::GetAnchorRect());
+  rect.Offset(0, -5);

[msw, 2011/12/08 00:40:14]

Please change this to rect.Inset(5, 5); Thanks!

[sail, 2011/12/08 01:41:10]

Unfortunately Inset() doesn't do the right thing since this is a 0x0 rect. Same
below.

[msw, 2011/12/08 06:26:41]

Bummer! okay, I'll fix it later.

+  return rect;
 }
 
 void BookmarkBubbleView::WindowClosing() {
   // We have to reset |bubble_| here, not in our destructor, because we'll be
   // destroyed asynchronously and the shown state will be checked before then.
   DCHECK(bookmark_bubble_ == this);
   bookmark_bubble_ = NULL;
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_BOOKMARK_BUBBLE_HIDDEN,
@@ skipping 197 matching lines @@
       const BookmarkNode* new_parent =
           parent_model_.GetNodeAt(parent_combobox_->selected_item());
       if (new_parent != node->parent()) {
         UserMetrics::RecordAction(
             UserMetricsAction("BookmarkBubble_ChangeParent"));
         model->Move(node, new_parent, new_parent->child_count());
       }
     }
   }
 }