Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a... (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
Avi (use Gerrit), Jói
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, ajwong+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's an internal content IPC struct. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113050

Patch Set 1 #

Patch Set 2 : remove view_messages.h include #

Patch Set 3 : Also get rid of content usage and remove the method #

Total comments: 1

Patch Set 4 : reupload original after revert #

Patch Set 5 : Remove the accidental commenting out that I had done before last commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -132 lines) Patch
M chrome/browser/chromeos/offline/offline_load_page_unittest.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 2 3 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 2 3 4 33 chunks +55 lines, -101 lines 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/test_tab_contents.h View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M content/browser/tab_contents/test_tab_contents.cc View 1 2 3 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years ago (2011-12-05 07:04:08 UTC) #1
Jói
LGTM http://codereview.chromium.org/8801003/diff/4002/chrome/browser/tab_contents/web_contents_unittest.cc File chrome/browser/tab_contents/web_contents_unittest.cc (right): http://codereview.chromium.org/8801003/diff/4002/chrome/browser/tab_contents/web_contents_unittest.cc#newcode417 chrome/browser/tab_contents/web_contents_unittest.cc:417: // Need this page id to be 2since ...
9 years ago (2011-12-05 10:30:50 UTC) #2
Avi (use Gerrit)
Reverted in r113025. [ RUN ] TabContentsTest.WebKitPrefs chrome/browser/tab_contents/web_contents_unittest.cc:908: Failure Value of: webkit_prefs.default_encoding Actual: "ISO-8859-1" Expected: ...
9 years ago (2011-12-05 21:20:34 UTC) #3
Avi (use Gerrit)
9 years ago (2011-12-05 22:04:29 UTC) #4
Latest patch set LGTM; feel free to trybot just the failed test.

Powered by Google App Engine
This is Rietveld 408576698