content/browser/tab_contents/test_tab_contents.h - Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/test_tab_contents.h

Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Remove the accidental commenting out that I had done before last commit Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/tab_contents/render_view_host_manager_unittest.cc ('k') | content/browser/tab_contents/test_tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tab_contents/test_tab_contents.h

===================================================================

--- content/browser/tab_contents/test_tab_contents.h (revision 113025)

+++ content/browser/tab_contents/test_tab_contents.h (working copy)

@@ -7,6 +7,7 @@

#pragma once

#include "content/browser/tab_contents/tab_contents.h"

+#include "content/public/common/page_transition_types.h"

#include "webkit/glue/webpreferences.h"

class TestRenderViewHost;

@@ -30,11 +31,15 @@

// alternatives without using command-line switches.

bool ShouldTransitionCrossSite() { return transition_cross_site; }

- // Promote DidNavigate to public.

void TestDidNavigate(RenderViewHost* render_view_host,

- const ViewHostMsg_FrameNavigate_Params& params) {

- DidNavigate(render_view_host, params);

- }

+ int page_id,

+ const GURL& url,

+ content::PageTransition transition);

+ void TestDidNavigateWithReferrer(RenderViewHost* render_view_host,

+ int page_id,

+ const GURL& url,

+ const content::Referrer& referrer,

+ content::PageTransition transition);

// Promote GetWebkitPrefs to public.

WebPreferences TestGetWebkitPrefs() {