content/browser/debugger/devtools_manager_unittest.cc - Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/debugger/devtools_manager_unittest.cc

Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Remove the accidental commenting out that I had done before last commit Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/web_contents_unittest.cc ('k') | content/browser/tab_contents/render_view_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/debugger/devtools_manager_unittest.cc

===================================================================

--- content/browser/debugger/devtools_manager_unittest.cc (revision 113025)

+++ content/browser/debugger/devtools_manager_unittest.cc (working copy)

@@ -218,10 +218,7 @@

const GURL url("http://www.google.com");

controller().LoadURL(

url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());

- ViewHostMsg_FrameNavigate_Params params1;

- InitNavigateParams(&params1, 1, url, content::PAGE_TRANSITION_TYPED);

- TestRenderViewHost* orig_rvh = rvh();

- contents()->TestDidNavigate(orig_rvh, params1);

+ contents()->TestDidNavigate(rvh(), 1, url, content::PAGE_TRANSITION_TYPED);

EXPECT_FALSE(contents()->cross_navigation_pending());

TestDevToolsClientHost client_host;

@@ -241,7 +238,7 @@

// Interrupt pending navigation and navigate back to the original site.

controller().LoadURL(

url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());

- contents()->TestDidNavigate(orig_rvh, params1);

+ contents()->TestDidNavigate(rvh(), 1, url, content::PAGE_TRANSITION_TYPED);

EXPECT_FALSE(contents()->cross_navigation_pending());

EXPECT_EQ(&client_host, devtools_manager->GetDevToolsClientHostFor(

DevToolsAgentHostRegistry::GetDevToolsAgentHost(rvh())));