chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc - Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Remove the accidental commenting out that I had done before last commit Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc ('k') | chrome/browser/tab_contents/web_contents_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

===================================================================

--- chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc (revision 113025)

+++ chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc (working copy)

@@ -11,7 +11,6 @@

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "content/browser/tab_contents/navigation_entry.h"

#include "content/browser/tab_contents/test_tab_contents.h"

-#include "content/common/view_messages.h"

#include "content/test/test_browser_thread.h"

using content::BrowserThread;

@@ -110,10 +109,9 @@

}

void Navigate(const char* url, int page_id) {

- ViewHostMsg_FrameNavigate_Params params;

- InitNavigateParams(

- &params, page_id, GURL(url), content::PAGE_TRANSITION_TYPED);

- contents()->TestDidNavigate(contents()->render_view_host(), params);

+ contents()->TestDidNavigate(

+ contents()->render_view_host(), page_id, GURL(url),

+ content::PAGE_TRANSITION_TYPED);

}

void GoBackCrossSite() {

@@ -122,10 +120,9 @@

contents()->controller().GoBack();

// The navigation should commit in the pending RVH.

- ViewHostMsg_FrameNavigate_Params params;

- InitNavigateParams(&params, entry->page_id(), GURL(entry->url()),

- content::PAGE_TRANSITION_TYPED);

- contents()->TestDidNavigate(contents()->pending_rvh(), params);

+ contents()->TestDidNavigate(

+ contents()->pending_rvh(), entry->page_id(), GURL(entry->url()),

+ content::PAGE_TRANSITION_TYPED);

}

void ShowInterstitial(bool is_subresource, const char* url) {