Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 8772064: Adds back BookmarkNode::IsVisible. Turns out we want to conditionally (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, estade+watch_chromium.org, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Adds back BookmarkNode::IsVisible. Turns out we want to conditionally show a node, so we need it. *SIGH* For the most part this is a revert of http://codereview.chromium.org/8759017/, so don't feel you need to review it that deeply. BUG=102714 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112897

Patch Set 1 #

Patch Set 2 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -369 lines) Patch
M chrome/browser/bookmarks/bookmark_extension_helpers.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 4 chunks +50 lines, -10 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_tree_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/webui/ntp/bookmarks_handler.cc View 1 chunk +0 lines, -335 lines 0 comments Download
M chrome/test/data/extensions/api_test/bookmark_manager/edit_disabled/test.js View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/models/tree_node_iterator.h View 3 chunks +34 lines, -4 lines 0 comments Download
M ui/base/models/tree_node_iterator_unittest.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
brett: bookmark_model. A future patch will add an explicit setter for the visibility of the ...
9 years ago (2011-12-02 23:29:06 UTC) #1
brettw
lgtm
9 years ago (2011-12-02 23:36:43 UTC) #2
Ben Goodger (Google)
lgtm On Fri, Dec 2, 2011 at 3:36 PM, <brettw@chromium.org> wrote: > lgtm > > ...
9 years ago (2011-12-02 23:39:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8772064/1001
9 years ago (2011-12-03 15:53:42 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-03 20:50:14 UTC) #5
Change committed as 112897

Powered by Google App Engine
This is Rietveld 408576698