chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm - Issue 8772064: Adds back BookmarkNode::IsVisible. Turns out we want to conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

Issue 8772064: Adds back BookmarkNode::IsVisible. Turns out we want to conditionally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tweaks Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

index b4739d223bbf39a63817f0a208048ad4ec9d8d09..16c7fc0f8a4c968aac4ffb6000fbdbfccd02537d 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

@@ -175,7 +175,11 @@ TEST_F(BookmarkBubbleControllerTest, TestFillInFolder) {

// Verify that the top level folders are displayed correctly.

EXPECT_TRUE([titles containsObject:@"Other Bookmarks"]);

EXPECT_TRUE([titles containsObject:@"Bookmarks Bar"]);

- EXPECT_TRUE([titles containsObject:@"Mobile Bookmarks"]);

+ if (model->mobile_node()->IsVisible()) {

+ EXPECT_TRUE([titles containsObject:@"Mobile Bookmarks"]);

+ } else {

+ EXPECT_FALSE([titles containsObject:@"Mobile Bookmarks"]);

+ }

}

// Confirm ability to handle folders with blank name.