chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm - Issue 8772064: Adds back BookmarkNode::IsVisible. Turns out we want to conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

Issue 8772064: Adds back BookmarkNode::IsVisible. Turns out we want to conditionally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tweaks Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

index 605c4ea989dedfdb7817830ae8b1902b13e720ce..bbf6628a7895be5dcae0f9ac9c05e3e7076a5f26 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

@@ -456,7 +456,7 @@ class BookmarkEditorBaseControllerBridge : public BookmarkModelObserver {

int childCount = node->child_count();

for (int i = 0; i < childCount; ++i) {

const BookmarkNode* childNode = node->GetChild(i);

- if (childNode->is_folder()) {

+ if (childNode->is_folder() && childNode->IsVisible()) {

NSString* childName = base::SysUTF16ToNSString(childNode->GetTitle());

NSMutableArray* children = [self addChildFoldersFromNode:childNode];

BookmarkFolderInfo* folderInfo =