Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3008)

Unified Diff: chrome/browser/bookmarks/bookmark_extension_helpers.cc

Issue 8772064: Adds back BookmarkNode::IsVisible. Turns out we want to conditionally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tweaks Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_extension_helpers.cc
diff --git a/chrome/browser/bookmarks/bookmark_extension_helpers.cc b/chrome/browser/bookmarks/bookmark_extension_helpers.cc
index cb44c0a18abebfb6e732796bd077651c46569482..a9873be6fd8f640a65d4352ed9c7933855631784 100644
--- a/chrome/browser/bookmarks/bookmark_extension_helpers.cc
+++ b/chrome/browser/bookmarks/bookmark_extension_helpers.cc
@@ -17,9 +17,11 @@ void AddNode(const BookmarkNode* node,
base::ListValue* list,
bool recurse,
bool only_folders) {
- base::DictionaryValue* dict = bookmark_extension_helpers::GetNodeDictionary(
- node, recurse, only_folders);
- list->Append(dict);
+ if (node->IsVisible()) {
+ base::DictionaryValue* dict = bookmark_extension_helpers::GetNodeDictionary(
+ node, recurse, only_folders);
+ list->Append(dict);
+ }
}
} // namespace
@@ -59,7 +61,7 @@ base::DictionaryValue* GetNodeDictionary(const BookmarkNode* node,
base::ListValue* children = new base::ListValue;
for (int i = 0; i < node->child_count(); ++i) {
const BookmarkNode* child = node->GetChild(i);
- if (!only_folders || child->is_folder()) {
+ if (child->IsVisible() && (!only_folders || child->is_folder())) {
DictionaryValue* dict = GetNodeDictionary(child, true, only_folders);
children->Append(dict);
}
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698