Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 8771030: base::Bind: Convert ServerSocket::Accept. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
csilv
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert ServerSocket::Accept. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112863

Patch Set 1 #

Patch Set 2 : Test build fix. #

Patch Set 3 : Test logic fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -44 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc View 1 2 4 chunks +13 lines, -9 lines 0 comments Download
M net/socket/server_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_client_socket_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket_libevent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket_libevent.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M net/socket/tcp_server_socket_unittest.cc View 1 5 chunks +11 lines, -10 lines 0 comments Download
M net/socket/tcp_server_socket_win.h View 3 chunks +3 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket_win.cc View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
9 years ago (2011-12-02 02:43:50 UTC) #1
csilv
9 years ago (2011-12-02 18:31:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698