Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: net/socket/tcp_server_socket_unittest.cc

Issue 8771030: base::Bind: Convert ServerSocket::Accept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Test logic fix. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/tcp_server_socket_libevent.cc ('k') | net/socket/tcp_server_socket_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/tcp_server_socket.h" 5 #include "net/socket/tcp_server_socket.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 }; 75 };
76 76
77 TEST_F(TCPServerSocketTest, Accept) { 77 TEST_F(TCPServerSocketTest, Accept) {
78 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 78 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
79 79
80 TestOldCompletionCallback connect_callback; 80 TestOldCompletionCallback connect_callback;
81 TCPClientSocket connecting_socket(local_address_list(), 81 TCPClientSocket connecting_socket(local_address_list(),
82 NULL, NetLog::Source()); 82 NULL, NetLog::Source());
83 connecting_socket.Connect(&connect_callback); 83 connecting_socket.Connect(&connect_callback);
84 84
85 TestOldCompletionCallback accept_callback; 85 TestCompletionCallback accept_callback;
86 scoped_ptr<StreamSocket> accepted_socket; 86 scoped_ptr<StreamSocket> accepted_socket;
87 int result = socket_.Accept(&accepted_socket, &accept_callback); 87 int result = socket_.Accept(&accepted_socket, accept_callback.callback());
88 if (result == ERR_IO_PENDING) 88 if (result == ERR_IO_PENDING)
89 result = accept_callback.WaitForResult(); 89 result = accept_callback.WaitForResult();
90 ASSERT_EQ(OK, result); 90 ASSERT_EQ(OK, result);
91 91
92 ASSERT_TRUE(accepted_socket.get() != NULL); 92 ASSERT_TRUE(accepted_socket.get() != NULL);
93 93
94 // Both sockets should be on the loopback network interface. 94 // Both sockets should be on the loopback network interface.
95 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 95 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
96 local_address_.address()); 96 local_address_.address());
97 97
98 EXPECT_EQ(OK, connect_callback.WaitForResult()); 98 EXPECT_EQ(OK, connect_callback.WaitForResult());
99 } 99 }
100 100
101 // Test Accept() callback. 101 // Test Accept() callback.
102 TEST_F(TCPServerSocketTest, AcceptAsync) { 102 TEST_F(TCPServerSocketTest, AcceptAsync) {
103 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 103 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
104 104
105 TestOldCompletionCallback accept_callback; 105 TestCompletionCallback accept_callback;
106 scoped_ptr<StreamSocket> accepted_socket; 106 scoped_ptr<StreamSocket> accepted_socket;
107 107
108 ASSERT_EQ(ERR_IO_PENDING, socket_.Accept(&accepted_socket, &accept_callback)); 108 ASSERT_EQ(ERR_IO_PENDING,
109 socket_.Accept(&accepted_socket, accept_callback.callback()));
109 110
110 TestOldCompletionCallback connect_callback; 111 TestOldCompletionCallback connect_callback;
111 TCPClientSocket connecting_socket(local_address_list(), 112 TCPClientSocket connecting_socket(local_address_list(),
112 NULL, NetLog::Source()); 113 NULL, NetLog::Source());
113 connecting_socket.Connect(&connect_callback); 114 connecting_socket.Connect(&connect_callback);
114 115
115 EXPECT_EQ(OK, connect_callback.WaitForResult()); 116 EXPECT_EQ(OK, connect_callback.WaitForResult());
116 EXPECT_EQ(OK, accept_callback.WaitForResult()); 117 EXPECT_EQ(OK, accept_callback.WaitForResult());
117 118
118 EXPECT_TRUE(accepted_socket != NULL); 119 EXPECT_TRUE(accepted_socket != NULL);
119 120
120 // Both sockets should be on the loopback network interface. 121 // Both sockets should be on the loopback network interface.
121 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 122 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
122 local_address_.address()); 123 local_address_.address());
123 } 124 }
124 125
125 // Accept two connections simultaneously. 126 // Accept two connections simultaneously.
126 TEST_F(TCPServerSocketTest, Accept2Connections) { 127 TEST_F(TCPServerSocketTest, Accept2Connections) {
127 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 128 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
128 129
129 TestOldCompletionCallback accept_callback; 130 TestCompletionCallback accept_callback;
130 scoped_ptr<StreamSocket> accepted_socket; 131 scoped_ptr<StreamSocket> accepted_socket;
131 132
132 ASSERT_EQ(ERR_IO_PENDING, 133 ASSERT_EQ(ERR_IO_PENDING,
133 socket_.Accept(&accepted_socket, &accept_callback)); 134 socket_.Accept(&accepted_socket, accept_callback.callback()));
134 135
135 TestOldCompletionCallback connect_callback; 136 TestOldCompletionCallback connect_callback;
136 TCPClientSocket connecting_socket(local_address_list(), 137 TCPClientSocket connecting_socket(local_address_list(),
137 NULL, NetLog::Source()); 138 NULL, NetLog::Source());
138 connecting_socket.Connect(&connect_callback); 139 connecting_socket.Connect(&connect_callback);
139 140
140 TestOldCompletionCallback connect_callback2; 141 TestOldCompletionCallback connect_callback2;
141 TCPClientSocket connecting_socket2(local_address_list(), 142 TCPClientSocket connecting_socket2(local_address_list(),
142 NULL, NetLog::Source()); 143 NULL, NetLog::Source());
143 connecting_socket2.Connect(&connect_callback2); 144 connecting_socket2.Connect(&connect_callback2);
144 145
145 EXPECT_EQ(OK, accept_callback.WaitForResult()); 146 EXPECT_EQ(OK, accept_callback.WaitForResult());
146 147
147 TestOldCompletionCallback accept_callback2; 148 TestCompletionCallback accept_callback2;
148 scoped_ptr<StreamSocket> accepted_socket2; 149 scoped_ptr<StreamSocket> accepted_socket2;
149 int result = socket_.Accept(&accepted_socket2, &accept_callback2); 150 int result = socket_.Accept(&accepted_socket2, accept_callback2.callback());
150 if (result == ERR_IO_PENDING) 151 if (result == ERR_IO_PENDING)
151 result = accept_callback2.WaitForResult(); 152 result = accept_callback2.WaitForResult();
152 ASSERT_EQ(OK, result); 153 ASSERT_EQ(OK, result);
153 154
154 EXPECT_EQ(OK, connect_callback.WaitForResult()); 155 EXPECT_EQ(OK, connect_callback.WaitForResult());
155 156
156 EXPECT_TRUE(accepted_socket != NULL); 157 EXPECT_TRUE(accepted_socket != NULL);
157 EXPECT_TRUE(accepted_socket2 != NULL); 158 EXPECT_TRUE(accepted_socket2 != NULL);
158 EXPECT_NE(accepted_socket.get(), accepted_socket2.get()); 159 EXPECT_NE(accepted_socket.get(), accepted_socket2.get());
159 160
160 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 161 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
161 local_address_.address()); 162 local_address_.address());
162 EXPECT_EQ(GetPeerAddress(accepted_socket2.get()).address(), 163 EXPECT_EQ(GetPeerAddress(accepted_socket2.get()).address(),
163 local_address_.address()); 164 local_address_.address());
164 } 165 }
165 166
166 TEST_F(TCPServerSocketTest, AcceptIPv6) { 167 TEST_F(TCPServerSocketTest, AcceptIPv6) {
167 bool initialized = false; 168 bool initialized = false;
168 ASSERT_NO_FATAL_FAILURE(SetUpIPv6(&initialized)); 169 ASSERT_NO_FATAL_FAILURE(SetUpIPv6(&initialized));
169 if (!initialized) 170 if (!initialized)
170 return; 171 return;
171 172
172 TestOldCompletionCallback connect_callback; 173 TestOldCompletionCallback connect_callback;
173 TCPClientSocket connecting_socket(local_address_list(), 174 TCPClientSocket connecting_socket(local_address_list(),
174 NULL, NetLog::Source()); 175 NULL, NetLog::Source());
175 connecting_socket.Connect(&connect_callback); 176 connecting_socket.Connect(&connect_callback);
176 177
177 TestOldCompletionCallback accept_callback; 178 TestCompletionCallback accept_callback;
178 scoped_ptr<StreamSocket> accepted_socket; 179 scoped_ptr<StreamSocket> accepted_socket;
179 int result = socket_.Accept(&accepted_socket, &accept_callback); 180 int result = socket_.Accept(&accepted_socket, accept_callback.callback());
180 if (result == ERR_IO_PENDING) 181 if (result == ERR_IO_PENDING)
181 result = accept_callback.WaitForResult(); 182 result = accept_callback.WaitForResult();
182 ASSERT_EQ(OK, result); 183 ASSERT_EQ(OK, result);
183 184
184 ASSERT_TRUE(accepted_socket.get() != NULL); 185 ASSERT_TRUE(accepted_socket.get() != NULL);
185 186
186 // Both sockets should be on the loopback network interface. 187 // Both sockets should be on the loopback network interface.
187 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 188 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
188 local_address_.address()); 189 local_address_.address());
189 190
190 EXPECT_EQ(OK, connect_callback.WaitForResult()); 191 EXPECT_EQ(OK, connect_callback.WaitForResult());
191 } 192 }
192 193
193 } // namespace 194 } // namespace
194 195
195 } // namespace net 196 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/tcp_server_socket_libevent.cc ('k') | net/socket/tcp_server_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698