Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: net/socket/tcp_server_socket_unittest.cc

Issue 8771030: base::Bind: Convert ServerSocket::Accept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Test logic fix. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_server_socket_libevent.cc ('k') | net/socket/tcp_server_socket_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_server_socket_unittest.cc
diff --git a/net/socket/tcp_server_socket_unittest.cc b/net/socket/tcp_server_socket_unittest.cc
index 8c36dca99503ff975dfa9466d29bc0e63a7ff715..573ff4c91ba08b8fa5b5f4d45b2034f8771208de 100644
--- a/net/socket/tcp_server_socket_unittest.cc
+++ b/net/socket/tcp_server_socket_unittest.cc
@@ -82,9 +82,9 @@ TEST_F(TCPServerSocketTest, Accept) {
NULL, NetLog::Source());
connecting_socket.Connect(&connect_callback);
- TestOldCompletionCallback accept_callback;
+ TestCompletionCallback accept_callback;
scoped_ptr<StreamSocket> accepted_socket;
- int result = socket_.Accept(&accepted_socket, &accept_callback);
+ int result = socket_.Accept(&accepted_socket, accept_callback.callback());
if (result == ERR_IO_PENDING)
result = accept_callback.WaitForResult();
ASSERT_EQ(OK, result);
@@ -102,10 +102,11 @@ TEST_F(TCPServerSocketTest, Accept) {
TEST_F(TCPServerSocketTest, AcceptAsync) {
ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
- TestOldCompletionCallback accept_callback;
+ TestCompletionCallback accept_callback;
scoped_ptr<StreamSocket> accepted_socket;
- ASSERT_EQ(ERR_IO_PENDING, socket_.Accept(&accepted_socket, &accept_callback));
+ ASSERT_EQ(ERR_IO_PENDING,
+ socket_.Accept(&accepted_socket, accept_callback.callback()));
TestOldCompletionCallback connect_callback;
TCPClientSocket connecting_socket(local_address_list(),
@@ -126,11 +127,11 @@ TEST_F(TCPServerSocketTest, AcceptAsync) {
TEST_F(TCPServerSocketTest, Accept2Connections) {
ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
- TestOldCompletionCallback accept_callback;
+ TestCompletionCallback accept_callback;
scoped_ptr<StreamSocket> accepted_socket;
ASSERT_EQ(ERR_IO_PENDING,
- socket_.Accept(&accepted_socket, &accept_callback));
+ socket_.Accept(&accepted_socket, accept_callback.callback()));
TestOldCompletionCallback connect_callback;
TCPClientSocket connecting_socket(local_address_list(),
@@ -144,9 +145,9 @@ TEST_F(TCPServerSocketTest, Accept2Connections) {
EXPECT_EQ(OK, accept_callback.WaitForResult());
- TestOldCompletionCallback accept_callback2;
+ TestCompletionCallback accept_callback2;
scoped_ptr<StreamSocket> accepted_socket2;
- int result = socket_.Accept(&accepted_socket2, &accept_callback2);
+ int result = socket_.Accept(&accepted_socket2, accept_callback2.callback());
if (result == ERR_IO_PENDING)
result = accept_callback2.WaitForResult();
ASSERT_EQ(OK, result);
@@ -174,9 +175,9 @@ TEST_F(TCPServerSocketTest, AcceptIPv6) {
NULL, NetLog::Source());
connecting_socket.Connect(&connect_callback);
- TestOldCompletionCallback accept_callback;
+ TestCompletionCallback accept_callback;
scoped_ptr<StreamSocket> accepted_socket;
- int result = socket_.Accept(&accepted_socket, &accept_callback);
+ int result = socket_.Accept(&accepted_socket, accept_callback.callback());
if (result == ERR_IO_PENDING)
result = accept_callback.WaitForResult();
ASSERT_EQ(OK, result);
« no previous file with comments | « net/socket/tcp_server_socket_libevent.cc ('k') | net/socket/tcp_server_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698